Skip to content

[FIX] Overly long function get_activity_history#274

Draft
arumes31 wants to merge 1 commit into
mainfrom
fix/refactor-get-activity-history-3571668139004658327
Draft

[FIX] Overly long function get_activity_history#274
arumes31 wants to merge 1 commit into
mainfrom
fix/refactor-get-activity-history-3571668139004658327

Conversation

@arumes31
Copy link
Copy Markdown
Owner

@arumes31 arumes31 commented Jun 2, 2026

Refactored the get_activity_history function in hookwise/api.py by extracting the log formatting and payload parsing logic into a private module-level helper function _format_webhook_log. This improves readability and maintainability of the API routes.

  • Extracted formatting logic to _format_webhook_log.
  • Simplified get_activity_history using a list comprehension.
  • Added tests/test_api_history.py to verify the endpoint functionality.
  • Updated tests/conftest.py with Redis mocking to support test execution.

PR created automatically by Jules for task 3571668139004658327 started by @arumes31

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce158d0d-87a0-4370-900d-c28782505b54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/refactor-get-activity-history-3571668139004658327

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread hookwise/api.py
"details": str(e)
}), 503

return jsonify({"status": "error", "message": "Failed to enqueue timeout check", "details": str(e)}), 503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants