[TEST] Missing tests for process_webhook_task error path#272
Conversation
Adds comprehensive tests for process_webhook_task retry and DLQ logic. Also adds tests for the cleanup_logs background task and implements global Redis mocking in tests/conftest.py to ensure test stability. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR addresses missing test coverage for the error-handling logic in
process_webhook_task. It ensures that:cleanup_logs) is verified to respect both default and custom retention policies.Additionally, global Redis mocking was added to the test suite to improve stability and prevent connection errors in non-Redis environments. It also fixes an issue where some tests failed because the
_appvariable intasks.pywasn't correctly initialized/injected during test execution.PR created automatically by Jules for task 17351356234223185930 started by @arumes31