🛡️ Sentinel: [security improvement] Improve CensorWriter log regex#248
🛡️ Sentinel: [security improvement] Improve CensorWriter log regex#248arumes31 wants to merge 1 commit into
Conversation
This commit enhances the regex used by the application's `CensorWriter` to accurately mask sensitive fields. The previous regex (`["':\s]+`) did not capture the `=` operator, which is commonly used in token definitions and URL query parameters (e.g., `token=...`).
The updated regex `(?i)(password|secret|token)(["':\s=]*[:=][\s"':=]*|\s*["']\s*)([^"'\s,{}]+)` resolves this and also prevents false positives in regular text (e.g., "I have a secret base").
Changes:
- Refined `censorRE` in `cmd/server/main.go`
- Added comprehensive unit tests in `cmd/server/main_test.go` to test `=` assignment, partial matches, and false positives.
Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
🛡️ Sentinel: [security improvement]
🚨 Severity: LOW / MEDIUM
💡 Vulnerability: The log censor regex failed to catch keys mapped using the
=character and could be prone to false positives.🎯 Impact: Sensitive fields formatted as
token=123might leak into application logs. Additionally, false positives might inadvertently censor valid log text.🔧 Fix: Refined
censorREto explicitly match=assignments and tighten the separator requirements to[:=]or quoted tokens, avoiding general whitespace masking.✅ Verification:
go test ./cmd/server/...confirms that all string formats, including=assignments and general plain text, are handled securely without false positives.PR created automatically by Jules for task 9251810033178029496 started by @arumes31