Skip to content

[FIX] N+1 Query in BulkLogAction#238

Draft
arumes31 wants to merge 1 commit into
mainfrom
fix/bulk-log-action-nplus1-10837821662872079808
Draft

[FIX] N+1 Query in BulkLogAction#238
arumes31 wants to merge 1 commit into
mainfrom
fix/bulk-log-action-nplus1-10837821662872079808

Conversation

@arumes31
Copy link
Copy Markdown
Owner

@arumes31 arumes31 commented Jun 4, 2026

This PR resolves an N+1 query pattern associated with audit logging in bulk operations.

Key changes:

  • Atomicity in Repository: Refactored PostgresRepository.BulkLogAction to use a database transaction. This ensures that the bulk insert (via unnest) and the bulk pruning (via row_number()) are executed as a single atomic unit.
  • Service-Level Optimization: Identified and fixed an N+1 pattern in ExternalSourceService.RefreshSource. Previously, it logged exclusions individually in a loop; it now uses BulkLogAction to record all changes in a single query.
  • Redundancy Prevention: Updated IPService.AddExcluded to skip individual audit logging when the actor is "system", avoiding duplicate log entries when called by the optimized ExternalSourceService.
  • Infrastructure Updates: Updated the PostgresRepositoryProvider interface and its mock implementation to include BulkLogAction, ensuring consistency and testability.

These changes improve performance during bulk IP processing (e.g., refreshing external threat feeds) and ensure data integrity in the audit logs.


PR created automatically by Jules for task 10837821662872079808 started by @arumes31

- Refactor `BulkLogAction` in `PostgresRepository` to use a transaction for atomicity.
- Optimize `ExternalSourceService` to use `BulkLogAction` instead of looping over individual `LogAction` calls.
- Update repository interface and mock to include `BulkLogAction`.
- Prevent redundant logging in `IPService.AddExcluded` for system-initiated bulk operations.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bb094977-62c0-462c-89eb-4170c1fb7d52

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bulk-log-action-nplus1-10837821662872079808

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant