[FIX] N+1 Query in BulkLogAction#238
Conversation
- Refactor `BulkLogAction` in `PostgresRepository` to use a transaction for atomicity. - Optimize `ExternalSourceService` to use `BulkLogAction` instead of looping over individual `LogAction` calls. - Update repository interface and mock to include `BulkLogAction`. - Prevent redundant logging in `IPService.AddExcluded` for system-initiated bulk operations. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR resolves an N+1 query pattern associated with audit logging in bulk operations.
Key changes:
PostgresRepository.BulkLogActionto use a database transaction. This ensures that the bulk insert (viaunnest) and the bulk pruning (viarow_number()) are executed as a single atomic unit.ExternalSourceService.RefreshSource. Previously, it logged exclusions individually in a loop; it now usesBulkLogActionto record all changes in a single query.IPService.AddExcludedto skip individual audit logging when the actor is "system", avoiding duplicate log entries when called by the optimizedExternalSourceService.PostgresRepositoryProviderinterface and its mock implementation to includeBulkLogAction, ensuring consistency and testability.These changes improve performance during bulk IP processing (e.g., refreshing external threat feeds) and ensure data integrity in the audit logs.
PR created automatically by Jules for task 10837821662872079808 started by @arumes31