Skip to content

[SECURITY] Directory Traversal in GeoIP Download#234

Draft
arumes31 wants to merge 1 commit into
mainfrom
fix/geoip-traversal-4554217155269103256
Draft

[SECURITY] Directory Traversal in GeoIP Download#234
arumes31 wants to merge 1 commit into
mainfrom
fix/geoip-traversal-4554217155269103256

Conversation

@arumes31
Copy link
Copy Markdown
Owner

@arumes31 arumes31 commented Jun 4, 2026

Fixed a directory traversal vulnerability in internal/tasks/geoip_task.go. The issue was that the edition parameter was not strictly validated, potentially allowing an attacker to influence URL construction or file paths.

I implemented a strict regex-based allow-list (^[a-zA-Z0-9-]+$) for the edition string and enforced it at all entry points:

  1. In NewGeoIPUpdateTask (constructor), preventing the creation of malicious tasks.
  2. In ProcessTask (handler), as a second layer of defense.
  3. In Download, to ensure the dynamic URL construction is safe.
  4. In getDBPath, as a defense-in-depth measure for file system operations.

Unit tests were updated to verify that traversal attempts are caught early and rejected.
The learning was recorded in .jules/sentinel.md.


PR created automatically by Jules for task 4554217155269103256 started by @arumes31

This commit fixes a directory traversal vulnerability in the GeoIP download
task. Although the input was previously escaped and used with filepath.Base,
the lack of strict validation allowed for potential edge cases.

Changes:
- Added a centralized regex validation for GeoIP edition strings.
- Enforced validation in NewGeoIPUpdateTask, ProcessTask, and Download.
- Added defense-in-depth validation in getDBPath to ensure filenames only
  contain allowed characters.
- Updated unit tests to verify that invalid inputs are rejected early.
- Documented the vulnerability and prevention in .jules/sentinel.md.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af4c4d79-6513-42cf-bb56-53fbdfb02024

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/geoip-traversal-4554217155269103256

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant