Skip to content

[TEST] Untested Prometheus Middleware#228

Draft
arumes31 wants to merge 1 commit into
mainfrom
test/prometheus-middleware-coverage-20260604-17937800305984555402
Draft

[TEST] Untested Prometheus Middleware#228
arumes31 wants to merge 1 commit into
mainfrom
test/prometheus-middleware-coverage-20260604-17937800305984555402

Conversation

@arumes31
Copy link
Copy Markdown
Owner

@arumes31 arumes31 commented Jun 4, 2026

This PR adds comprehensive unit tests for the PrometheusMiddleware in the internal/api package.

Changes

  • Created internal/api/prometheus_middleware_test.go with multiple test cases.
  • Verified that c.FullPath() correctly captures route patterns as labels.
  • Verified that unregistered routes are labeled as "unknown".
  • Verified that aborted requests (e.g., using c.AbortWithStatus) are correctly recorded with their respective status codes.
  • Confirmed that the MetricHttpDuration histogram is correctly incremented for each request.

Testing

  • Ran go test -v -cover ./internal/api
  • Verified PrometheusMiddleware coverage reached 100%.
  • Verified all other tests in the package pass.

PR created automatically by Jules for task 17937800305984555402 started by @arumes31

Added unit tests to internal/api/prometheus_middleware_test.go to verify:
- Correct recording of route patterns (e.g., /test/:id)
- Handling of unknown routes (defaults to "unknown")
- Metric recording for aborted requests (e.g., 403 Forbidden)
- Incremental updates to MetricHttpDuration histogram

This ensures 100% test coverage for the PrometheusMiddleware function.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b7d8962-62d7-43e4-be69-3f79aeff5d63

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/prometheus-middleware-coverage-20260604-17937800305984555402

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant