[TEST] Untested Prometheus Middleware#228
Conversation
Added unit tests to internal/api/prometheus_middleware_test.go to verify: - Correct recording of route patterns (e.g., /test/:id) - Handling of unknown routes (defaults to "unknown") - Metric recording for aborted requests (e.g., 403 Forbidden) - Incremental updates to MetricHttpDuration histogram This ensures 100% test coverage for the PrometheusMiddleware function. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR adds comprehensive unit tests for the PrometheusMiddleware in the internal/api package.
Changes
internal/api/prometheus_middleware_test.gowith multiple test cases.c.FullPath()correctly captures route patterns as labels.c.AbortWithStatus) are correctly recorded with their respective status codes.MetricHttpDurationhistogram is correctly incremented for each request.Testing
go test -v -cover ./internal/apiPrometheusMiddlewarecoverage reached 100%.PR created automatically by Jules for task 17937800305984555402 started by @arumes31