Fit the LLM dialogs to the window and line up their price fields - #180
Merged
Merged
Conversation
The Add model dialog was taller than a laptop window: it ran off screen and its Cancel and Add buttons were only partly visible. The price inputs also sat at different heights, because a label that wraps for its "optional" marker is taller than one that does not. - The model and provider dialogs are capped at the window height. Their fields scroll inside, and the buttons stay pinned at the bottom. - Each price field spans three rows of a CSS subgrid (label, input, check box), so the two labels of a row share one height and both inputs sit on one line. - A contract test holds both rules and the markup that uses them.
The rate grid replaced .field-row-2, so the 560px breakpoint that stacks the other field rows no longer reached the price fields: at 320px each input was 116px wide. Add .rate-grid to that breakpoint, and hold it in the dialog contract test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Operator feedback (2026-09-27): the Add model dialog did not fit a laptop window. Its Cancel and Add buttons were only partly visible, and the price inputs sat at different heights and "jumped" between lines.
What changed
.modal.tall) are capped at100vh - 40px. Their fields scroll inside; the buttons are sticky at the bottom.<label>isdisplay: contents, so its text and input each take a row and it still labels the input.llmDialogs.contract.test.tsholds the rules and the markup (layout cannot be measured in jsdom).Verification
SettingsLlmModelFormrendered withindex.cssat 1366×768. Buttons visible at top and bottom of the scroll; paired inputs at the same height in every row.tscand production build pass.display: contents, the max-height,modal tallon the model form, therate-fieldclass) — each fails the contract test.