Fix the screens the first subscription build walked through - #179
Merged
Merged
Conversation
What the operator hit on the first live subscription build: - Harness keys: a switched-off key or seat can now be deleted. One no run used is removed; one a run used has its secret erased and leaves the screen, keeping only the name the run shows (V86). Switching off alone kept the key or the person's sign-in stored for ever. - Build setup: the form says which fields keep it from saving, instead of a Save button that silently does nothing. - Work items: says that tickets arrive by a scheduled scan, so a new one can take a minute or two to appear. - Approval panel: shows how the build pays, and labels which text is the specification and which the one-step plan. - Work item page: reads the item again every 10 seconds while no panel is open, like Runs, so a gate or a finished build shows without a click. - Verify stop: says verification is not built yet and the result is held, with no push and no pull request. - Ticket source: names the account by role and bot handle. Two accounts shared one name, so the reviewer account had been picked unseen.
- A key picked in the last hour is erased rather than deleted: a dispatch picks a key and writes its run a moment later, outside one transaction, so deleting could fail that run's insert. - The API-key pick re-checks, after waiting for a row, that the key is still on and not erased, so an erased key is never returned and read as a corrupt one. - The work item page numbers its reads and shows only the newest; polls never overlap and none is applied after a panel opens.
The first poll supersedes a first load still out, whose answer is then dropped; the poll now fills an empty page instead of only updating one, so a slow first load no longer leaves the page loading for ever.
… button - A first load overtaken by a poll now has its error dropped like its answer, so an obsolete error never replaces the item the poll showed. - ReviewDetail.archive waited the default second for the Archive button, and failed under full-suite load; it waits five now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first live subscription build (ticket spire-test #37) worked end to end: it paid with the seat, recorded 69,888 cached input, 4,103 input and 730 output tokens as unmetered, and cost 0. The operator's walk through the screens found seven rough edges. This PR fixes them.
What
api_keynullable,erased_at, label unique among live rows only). A member still switched on is refused withharness_credential_still_on.verify_capability_unavailablenow says verification is not built yet and the result is held: no push, no pull request.public-github · github · Reviewer · @code-spire-mole). Two accounts shared the namepublic-github, so the reviewer account had been picked as the ticket source without it being visible. That is why the ticket comment came from mole. The setting itself is the operator's to change.Checks
npm run buildpasses. One run sawReviewDetail.archivefail once under load; it passes alone twice and in a full re-run, and this PR does not touch it.