Skip to content

Django 3 support#41

Closed
fmalina wants to merge 19 commits into
arteria:masterfrom
fmalina:master
Closed

Django 3 support#41
fmalina wants to merge 19 commits into
arteria:masterfrom
fmalina:master

Conversation

@fmalina
Copy link
Copy Markdown

@fmalina fmalina commented Dec 16, 2019

Supersedes and closes #28, #29, #32, #33, #37

Copy link
Copy Markdown

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@francoArdiles
Copy link
Copy Markdown

I got an error with the setup encoding in windows with python 3.8, it gets fixed adding the encoding to the descriptions in the file similar to #35

setup( . . . description=open('DESCRIPTION', encoding="utf-8").read(), long_description=open('README.rst', encoding="utf-8").read(), . . . )

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 6, 2021

Coverage Status

Coverage increased (+0.1%) to 85.668% when pulling fe9321a on fmalina:master into 6bad475 on arteria:master.

@jayvdb
Copy link
Copy Markdown

jayvdb commented Feb 10, 2021

@fmalina The last commit, https://github.com/fmalina/django-openinghours/commit/9d8929989d84fd2b30daea40691a37ced6fe4944, broke my poetry based project which was using fmalina:master.

@arteria, could you please take a look at this, and fast-forward all except the last commit in this PR.

@fmalina
Copy link
Copy Markdown
Author

fmalina commented Feb 10, 2021

@jayvdb I am using pip3 install git+git://github.com/fmalina/django-openinghours.git#egg=openinghours and it breaks for me without the last change

@fmalina
Copy link
Copy Markdown
Author

fmalina commented Feb 10, 2021

@jayvdb I reverted it and started to use pip3 install git...#egg=django-openinghours and that seems to work

@fmalina fmalina closed this by deleting the head repository May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants