Repository navigation
fix(demo): make showcase header edge-to-edge and add live demo url to readme - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #32:
/demo?view=handout,renderHandoutHtmlhad an 800px max-width and 24px padding onbody, squishing the dark demo bar and wrapping the role switcher links. Overrode the layout so.demo-showcase-barspans 100% full width edge-to-edge across the top of the browser on all views, and wrapped the handout document in a centered 800px paper sheet preview (.demo-handout-sheet).https://practitioner-protocols-production.up.railway.app/demoas a hero badge link under the title and in Section 1 (Overview & Vision) detailing the 4 role previews.Verification
npm test: 606/606 passing<!DOCTYPE html>across all demo views (portal,client,handout,admin).