Repository navigation
fix(admin): replace alert() in starter modal with in-page messages (#29) - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #29
Replaces all native browser
alert()dialogs in the Merchant Admin Starter Template modal with accessible, in-page error messages compatible with modern embedded admin iframes onadmin.shopify.com.Changes
Eliminated
alert()Calls:Invalid variant: must be a product variant GID)This product variant is already in the starter template.)Maximum 20 lines allowed per starter template.)Please enter a variant GID.)Variant ID must be numeric or gid://shopify/ProductVariant/<id>)Could not load product variants)Please add at least one product line item to the starter template.)Unified In-Page Message Handling (
app/lib/protocols/admin.js):showStarterMessage(msg, isError, asHtml)andclearStarterMessage().#admin-starter-search-messagerendered in normal document flow.role="alert"for errors androle="status"for notices for screen-reader accessibility.Automated Testing (
test/admin.test.js):alert()calls in the starter modal logic and verifying in-page error message strings.