Repository navigation
fix: resolve demo gaps, copy accuracy, handout qr, and attribution currency - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 7 gaps identified during the end-to-end dev store demo recording between README/guide claims and live app behavior, followed by Liquid injection security hardening and App Bridge resource picker integration:
Printable Handout with QR Code (
?handout=1):renderHandoutHtmlfromhandout.js, rendering practice branding, intro note, item usage notes, shophandoutText, footer disclaimer, and inline SVG QR code pointing to the absolute storefront share URL (https://${shop}/apps/protocols/${token}).@page { size: auto; margin: 12mm; }, page break protections) with user-initiated "Print" button.{,},%) usingescapeHtmlimported fromproxy.js({,},%) across all dynamic fields, eliminating template injection risks when rendered asapplication/liquid.<meta name="robots" content="noindex, nofollow">into<head>so the document starts cleanly with{% layout none %}\n<!DOCTYPE html>without triggering quirks mode.Storefront Clipboard Copy ("Copy Link"):
.portal-copy-link-btn) to copy the absolute share URL vianavigator.clipboard.writeTextwith transparent fallback to hidden textareadocument.execCommand('copy').hrefas fallback.Starter Template Modal & Native Resource Picker:
#admin-starter-search-message) into normal document flow (position: static; margin-top: 0.75rem;), eliminating overlay blockage of the "Advanced: Enter Variant GID directly" toggle.#admin-starter-advanced-detailswhenever catalog search is unavailable.window.shopify.resourcePicker({ type: 'product', multiple: true })and otherwise shows the manual-GID message.gid://shopify/ProductVariant/...GIDs (rejects product GIDs), handles user cancellation, and displays an in-flow warning if a selected product has no selectable variants.Copy Accuracy & Zero Health Claims:
Navigation Path & Authentic Customer Flow:
Online Store > Navigation(/admin/menus) to modern Shopify AdminContent > Menus(https://admin.shopify.com/store/${shopHandle}/content/menus).target="_top"for reliable iframe navigation.Attribution Currency Clarity:
Attributed Revenuewithout duplicate currency code.Regression Guard Test Coverage:
test/handout.test.js,test/routes.test.js,test/portal.test.js, andtest/admin.test.js.Unverified Live Checklist (To Be Tested on Live Dev Store After Merge/Deploy)
?handout=1).Copy Link).shopify.resourcePickerbehavior inside the embedded admin iframe withoutread_productsscope (docs do not specify whetherread_productsis required for merchant-facing App Bridge picker).Content > Menus(/content/menus).Scope and Privacy Integrity
read_orders. No new scopes added.