Repository navigation
fix(admin): confirmation notices and JSON responses for admin forms - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/lib/protocols/routes.jsto checkAccept: application/jsonbefore any form redirect, returning HTTP 200 JSON with{ success: true, notice: ..., message: ... }and no 303 redirect.Accept: application/json(plain non-JS form submit), 303/302 redirects point to legitimate routes (/admin?tab=settings¬ice=feedback_saved,/admin?tab=settings¬ice=request_sent,/admin?tab=settings¬ice=settings_saved,/admin?tab=contacts), never/api/admin.app/lib/protocols/admin.js, on successful submission, client script sets allow-listed notice query parameter (feedback_saved,request_sent,settings_saved) and reloads with a fresh sessionid_token.renderSettingsTabrenders a small dismissible.Polaris-Banner--statusSuccesswith text escaped. Unknown notice keys render nothing, and user text/email is never placed in the URL query string..Polaris-Banner--statusCriticaland alert instead of generic 'Action failed'.