Skip to content

fix(profile): use shopAddress for store country - #23

Merged
arsalan-arshad merged 1 commit into
mainfrom
fix/shop-profile-query
Nov 5, 2026
Merged

arsalan-arshad merged 1 commit into
mainfrom
fix/shop-profile-query

Conversation

@arsalan-arshad

Copy link
Copy Markdown
Owner

Summary

  • Fixes ShopProfile empty record bug on live store by replacing deprecated billingAddress { countryCodeV2 } with shopAddress { countryCodeV2 } in syncShopProfile Admin GraphQL query.
  • Confirmed field schema validity using official Shopify Dev MCP validation (Shop.shopAddress valid, billingAddress deprecated/rejected).
  • Logs single non-PII warning line truncated to 200 chars on GraphQL errors ([ShopProfile] GraphQL error for <shop>: <message>).
  • Aligns /privacy page text and documentation to specify store country from shop address.
  • Updates test mocks and asserts that the query contains shopAddress and strictly excludes billingAddress.

Verified:

  • npm test: 578 unit tests passing across 132 suites.
  • npm run test:all: 589 tests (578 passed, 11 live DB skipped).

Unverified:

  • Live sync against a real store.

@arsalan-arshad
arsalan-arshad merged commit 1b037a9 into main Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant