fix(react): use SDK db API in query hook#6
Open
hardikdhingra150 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useQueryto use the public SDK app API:app.db(collectionName)collection.subscribe()and perform a guarded initial load insteadinsertandremovemutations_idthrough the collection filter APIZerithDBAppand add a patch changeset forzerithdb-reactBug Context
The active parent repository has Issues disabled, so I could not open an upstream issue first. I attempted to create one and GitHub returned HTTP 410. The bug is that
useQuerytreateduseZerith()as a rawDbClientwithcollection(), whilecreateApp()exposes collections throughapp.db(name). It also attempted to callcollection.subscribe(), which is not present on the currentCollectionClientimplementation.Validation
pnpm exec prettier --check packages/react/src/index.tsx .changeset/fix-react-use-query-sdk-api.mdpnpm --filter zerithdb-react buildNote:
pnpm --filter zerithdb-react exec tsc --noEmitis currently blocked by existing monorepo path resolution issues insdk/srcimports for sibling package names.