fix(installer): stop double-opening browser at the connect prompt

[Harihara04sudhan]

Bug

User presses Y at "Connect your ArmorIQ account now?" → two browser tabs open with two unrelated device codes:

1. First tab: dev.armoriq.io/auth/device?code=2NWM-RK69&callback=http://localhost:55156/callback (no product param, generic "Authorize Device" page)
2. Second tab: dev.armoriq.io/auth/device?code=NTUK-TE8D&callback=http://localhost:55164/callback&product=armorcopilot (branded "Authorize ArmorCopilot" page)

Different ports = two separate cmdLogin invocations spawning two local callback servers.

Root cause

The installer feature-detected --product support by running:

if armoriq-dev login --help 2>&1 | grep -q -- '--product'; then ...

But the SDK's login subcommand has no --help handler — it just runs the full device-code flow with --help parsed as an unknown flag. That's tab #1.

The grep then fails (the login flow's stdout doesn't contain "--product"), so the script falls into the else branch and runs the env-var fallback: ARMORIQ_PRODUCT=armorcopilot armoriq-dev login. That's tab #2.

Fix

Drop the probe entirely. Always pass --product as a flag AND export ARMORIQ_PRODUCT as a fallback. New SDKs prefer the flag, old SDKs ignore the unknown flag and pick up the env var. Either way: one CLI call, one device code, one browser tab.

-  if command -v armoriq-dev >/dev/null 2>&1; then
-    if armoriq-dev login --help 2>&1 | grep -q -- '--product'; then
-      armoriq-dev login --product "${product}" && login_ok=1 || login_ok=0
-    else
-      ARMORIQ_PRODUCT="${product}" armoriq-dev login && login_ok=1 || login_ok=0
-    fi
-  elif ...
+  export ARMORIQ_PRODUCT="${product}"
+  if command -v armoriq-dev >/dev/null 2>&1; then
+    armoriq-dev login --product "${product}" && login_ok=1 || login_ok=0
+  elif ...

Follow-ups

1. armorCodex installer has the same probe pattern — mirror PR coming.
2. SDK armoriq-sdk-customer-ts/dev should add a per-subcommand --help handler so future probes don't accidentally trigger the device-code flow. Separate PR.
3. Landing repo install_armorcopilot.sh needs a sync PR after this merges.

Test plan

• Clean local state (rm -rf ~/.armoriq/armorCopilot ~/.copilot/armorcopilot ~/.armoriq/credentials.json).
• Run curl -fsSL https://armoriq.ai/install_armorcopilot.sh | bash (or sync this branch into landing first).
• Press Y at the connect prompt → exactly one browser tab opens at dev.armoriq.io/auth/device?...&product=armorcopilot showing "Authorize ArmorCopilot".

🤖 Generated with Claude Code