Skip to content

chore(plugin): HOL Plugin Scanner compliance — score 92/100, zero high/critical#25

Merged
Harihara04sudhan merged 1 commit into
mainfrom
chore/hol-scanner-compliance
Jun 9, 2026
Merged

chore(plugin): HOL Plugin Scanner compliance — score 92/100, zero high/critical#25
Harihara04sudhan merged 1 commit into
mainfrom
chore/hol-scanner-compliance

Conversation

@Harihara04sudhan

Copy link
Copy Markdown
Contributor

Why

Maintainer of hashgraph-online/awesome-codex-plugins#189 (@internet-dot) requires the HOL Plugin Scanner running in this repo's CI, and the plugin must score 80+/130 with no high/critical findings, before our README listing can be restored. This PR meets both bars.

Scanner result

Before: 67/100 (D), 3 HIGH findings (HARDCODED_SECRET in test fixtures)
After: 92/100 (A), 0 high/critical

Findings: critical:0, high:0, medium:0, low:1, info:1

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Final Score: 92/100 (A - Excellent)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Changes

File Purpose
.github/workflows/hol-plugin-scanner.yml Required CI per maintainer spec. Uses hashgraph-online/ai-plugin-scanner-action@v1, min_score: 80, fail_on_severity: high, uploads SARIF
.github/dependabot.yml Weekly npm + github-actions updates (closes one scanner warning)
plugins/armorcodex/README.md Bundle-level README, points at repo root for full docs
plugins/armorcodex/LICENSE MIT, matches the license field in package.json
plugins/armorcodex/SECURITY.md Vuln reporting contact + supported versions
plugins/armorcodex/.codexignore Excludes node_modules/, build cruft
plugins/armorcodex/.plugin-scanner.toml Scanner config (currently empty/default; placeholder for future tuning)
tests/*.mjs moved up from plugins/armorcodex/tests/ Three test files (intent.test.mjs, lifecycle.test.mjs, iap-service.test.mjs) triggered false-positive HARDCODED_SECRET findings on the scanner's file-level heuristics. Tests don't belong INSIDE the plugin distribution dir anyway. Imports updated from ../scripts/ to ../plugins/armorcodex/scripts/. All 23 tests pass.

Verification

$ pipx install plugin-scanner && plugin-scanner scan plugins/armorcodex
Final Score: 92/100 (A - Excellent)
Findings: critical:0, high:0

$ node --test tests/
ℹ tests 23  pass 23  fail 0  duration_ms 85.67

Test plan

Refs

🤖 Generated with Claude Code

…/critical)

Required by hashgraph-online/awesome-codex-plugins maintainer (PR #189) to
get our restored README listing merged. Brings the bundle to scanner v2's
'public-marketplace' bar.

Changes:
- Add plugins/armorcodex/README.md (bundle-level, points at root README)
- Add plugins/armorcodex/LICENSE (MIT, matches package.json)
- Add plugins/armorcodex/SECURITY.md (vuln reporting contact)
- Add plugins/armorcodex/.codexignore (exclude node_modules/, build cruft)
- Add plugins/armorcodex/.plugin-scanner.toml (scanner config)
- Add .github/dependabot.yml (npm + github-actions weekly updates)
- Add .github/workflows/hol-plugin-scanner.yml (CI per maintainer spec —
  uses hashgraph-online/ai-plugin-scanner-action@v1, min_score: 80,
  fail_on_severity: high, uploads SARIF)
- Move tests/ out of plugins/armorcodex/ to repo root. Three test files
  (intent.test.mjs, lifecycle.test.mjs, iap-service.test.mjs) were
  triggering false-positive HARDCODED_SECRET findings on the scanner's
  file-level heuristics. Moving them outside the plugin distribution dir
  (where they don't belong anyway) resolves all 3 high findings.
- Update test imports from "../scripts/" to "../plugins/armorcodex/scripts/"
  for the new location. All 23 tests pass.

Scanner result before: 67/100 (D), 3 high findings
Scanner result after:  92/100 (A), 0 high/critical findings

Refs hashgraph-online/awesome-codex-plugins#189 (maintainer comment by
@internet-dot requiring the scanner workflow + 80+ score before the
README restore can be merged).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@Harihara04sudhan Harihara04sudhan merged commit 5307fa0 into main Jun 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants