chore(plugin): HOL Plugin Scanner compliance — score 92/100, zero high/critical#25
Merged
Merged
Conversation
…/critical) Required by hashgraph-online/awesome-codex-plugins maintainer (PR #189) to get our restored README listing merged. Brings the bundle to scanner v2's 'public-marketplace' bar. Changes: - Add plugins/armorcodex/README.md (bundle-level, points at root README) - Add plugins/armorcodex/LICENSE (MIT, matches package.json) - Add plugins/armorcodex/SECURITY.md (vuln reporting contact) - Add plugins/armorcodex/.codexignore (exclude node_modules/, build cruft) - Add plugins/armorcodex/.plugin-scanner.toml (scanner config) - Add .github/dependabot.yml (npm + github-actions weekly updates) - Add .github/workflows/hol-plugin-scanner.yml (CI per maintainer spec — uses hashgraph-online/ai-plugin-scanner-action@v1, min_score: 80, fail_on_severity: high, uploads SARIF) - Move tests/ out of plugins/armorcodex/ to repo root. Three test files (intent.test.mjs, lifecycle.test.mjs, iap-service.test.mjs) were triggering false-positive HARDCODED_SECRET findings on the scanner's file-level heuristics. Moving them outside the plugin distribution dir (where they don't belong anyway) resolves all 3 high findings. - Update test imports from "../scripts/" to "../plugins/armorcodex/scripts/" for the new location. All 23 tests pass. Scanner result before: 67/100 (D), 3 high findings Scanner result after: 92/100 (A), 0 high/critical findings Refs hashgraph-online/awesome-codex-plugins#189 (maintainer comment by @internet-dot requiring the scanner workflow + 80+ score before the README restore can be merged). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Maintainer of hashgraph-online/awesome-codex-plugins#189 (@internet-dot) requires the HOL Plugin Scanner running in this repo's CI, and the plugin must score 80+/130 with no high/critical findings, before our README listing can be restored. This PR meets both bars.
Scanner result
Before: 67/100 (D), 3 HIGH findings (HARDCODED_SECRET in test fixtures)
After: 92/100 (A), 0 high/critical
Changes
.github/workflows/hol-plugin-scanner.ymlhashgraph-online/ai-plugin-scanner-action@v1,min_score: 80,fail_on_severity: high, uploads SARIF.github/dependabot.ymlplugins/armorcodex/README.mdplugins/armorcodex/LICENSElicensefield inpackage.jsonplugins/armorcodex/SECURITY.mdplugins/armorcodex/.codexignorenode_modules/, build cruftplugins/armorcodex/.plugin-scanner.tomltests/*.mjsmoved up fromplugins/armorcodex/tests/intent.test.mjs,lifecycle.test.mjs,iap-service.test.mjs) triggered false-positive HARDCODED_SECRET findings on the scanner's file-level heuristics. Tests don't belong INSIDE the plugin distribution dir anyway. Imports updated from../scripts/to../plugins/armorcodex/scripts/. All 23 tests pass.Verification
Test plan
node --test tests/passes all 23 testsRefs
🤖 Generated with Claude Code