Repository navigation
fix(deps): require ZIPFoundation by version so consumers can resolve OpenTDFKit - #58
Conversation
…OpenTDFKit Since 4.0.2 the manifest pinned ZIPFoundation to a revision (e7a17d5). SwiftPM refuses a package required by a stable version when it depends on an unstable (revision) version, so every consumer that requires OpenTDFKit by version fails to resolve 4.0.2 and 5.0.0: 'opentdfkit' >= 5.0.0 cannot be used because package 'opentdfkit' is required using a stable-version but 'opentdfkit' depends on an unstable-version package 'zipfoundation' That is why ArkavoKit, ArkavoMediaKit, Creator and arkavo-ios still resolve 4.0.1. Require ZIPFoundation from 0.9.20, its latest release. The revision only avoided 0.9.20's watchOS deployment-target warning (#388); no OpenTDFKit code needs anything after 0.9.20. Build and tests against 0.9.20: 288 tests, 11 skipped, one failure, StreamingBenchmarkTests.testMemoryUsageWith2MBChunk (peak-memory bound in a local debug run), which fails identically on unmodified 5.0.0 with the revision pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTtgscNah3Wk739yom9NPF
Code Review ✅ Approved🟡 Medium risk · Replacing ZIPFoundation’s pinned revision with release 0.9.20 changes the resolved archive dependency and could alter ZIP processing behavior for consumers. Changes the ZIPFoundation dependency in
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Problem
Since 4.0.2,
Package.swiftpins ZIPFoundation to a revision (e7a17d5). SwiftPM won't resolve a package that is required by a stable version when that package depends on a revision, so no consumer that requires OpenTDFKit by version can resolve 4.0.2 or 5.0.0:That is why ArkavoKit, ArkavoMediaKit, Creator and arkavo-ios all still resolve 4.0.1.
Change
from: "0.9.20", its latest release.Package.resolvednow records 0.9.20 (22787ff).Verification
swift build --build-testspasses.swift test: 288 tests, 11 skipped, 1 failure.StreamingBenchmarkTests.testMemoryUsageWith2MBChunk, a peak-memory bound measured in a local debug run (about 214 MB against a 70 MB limit).Once this merges, tag 5.0.1 so consumers can move to the 5.x line.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TTtgscNah3Wk739yom9NPF