fix: move selection to adjacent item after session deletion#255
Open
ariane-emory wants to merge 1 commit intodevfrom
Open
fix: move selection to adjacent item after session deletion#255ariane-emory wants to merge 1 commit intodevfrom
ariane-emory wants to merge 1 commit intodevfrom
Conversation
When deleting a session in the session list dialog, the selection now moves to an adjacent item (next or previous) instead of staying at the same index which could point to a non-adjacent session. Changes: - Expose moveTo function in DialogSelectRef - Track index before deletion in dialog-session-list - Move to adjacent item after successful deletion This fix is compatible with session grouping and bookmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
When deleting a session in the session list dialog, the selection now moves to an adjacent item (next or previous) instead of staying at the same index which could point to a non-adjacent session.
Changes: