feat: renaming sessions doesn't close session list#233
Open
ariane-emory wants to merge 16 commits intodevfrom
Open
feat: renaming sessions doesn't close session list#233ariane-emory wants to merge 16 commits intodevfrom
ariane-emory wants to merge 16 commits intodevfrom
Conversation
After renaming a session from the session_list dialog, instead of closing all dialogs, the session_list dialog reopens with the renamed session selected. - Add onSuccess/onCancel callbacks to DialogSessionRename - Add initialSessionID prop to DialogSessionList for selection - Pass callbacks to return to session list after rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Causes the
session_listwindow to remain open after renaming a session, so as to improve the UX when renaming multiple sessions.