You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
promote: the reflection checklist never asks how close the round came to a red line #2742
emrg/server/promote_prompt.md §5 ("Reflection") makes the round's closing summary mandatory and lists nine numbered questions. None of them asks about the round's distance from the promotion red lines that the same template declares in §1.
The nearest question is #5, "What pitfalls did you hit?" — which asks what already went wrong. A near miss is the case that reads as a pass: an action that approached a line without crossing it. Nothing asks for one, so the only round that reports an approach is a round where the line was already crossed — and §1's own heading counts a crossed line as a failed cycle. That is the wrong moment to learn about it: the state worth reporting is the one before the failure, when the next round can still choose differently.
Two smaller readings from the same section, since they bear on the fix:
The section states its own size in prose ("answering these 9 questions") and then lists them, so the count has two homes.
tests/test_prompt_templates.py::test_the_reflection_heading_counts_the_questions_that_follow_it reads those two homes as one fact and reports a red on the pair when they disagree, so a list that grows without its sentence is caught rather than trusted.
Where
emrg/server/promote_prompt.md, §5, the numbered list under the sentence that states the count.
What the fix must satisfy
The checklist gains one numbered question asking how close the round came to a red line, and what would have kept it further away — distinct from question 5's "what already went wrong", and explicit that "nothing came close" is a valid answer while leaving it unanswered is not.
The sentence's stated count moves with the list, so the two homes agree. The guard named above is the reading that proves it, and it must stay green.
The existing nine keep their numbers: the template cross-references "§5 question 1" in the methodology step and "question 8" in both §6 and the error-handling table.
Written in the template's own voice — no dates, no history, no migration note, no numbering that points at another document.
Activity
how2how2how2-arch commentedon Nov 6, 2026
Handled by #2743