strRepeat : new implementation#1408
Draft
shkel wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
@alstrup what do you think ? |
alstrup
approved these changes
Nov 14, 2024
Contributor
alstrup
left a comment
alstrup
left a comment
There was a problem hiding this comment.
OK with me. I guess we could do some divide and concur and do bigger chunks at a time, but this works.
shkel
commented
Nov 19, 2024
| s; | ||
| } else { | ||
| // list2string(generateList(0, cnt, \__ -> s)); | ||
| p = generateProgressString(cnt, makeList1(s), 1, 1); |
Contributor
Author
There was a problem hiding this comment.
@alstrup like list2string(generateList(0, cnt, __ -> s)) more . but maybe i didn't understand you
Contributor
|
The simple one with list2string was fine. We do not need the complicated version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if cnt ~= 18000 we have max call stack error.