Skip to content

security: move x-App-Secret to env var + deprecate ROPC password grant #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AidanDalyAus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

security: move x-App-Secret to env var + deprecate ROPC password grant #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion jlrpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
""" Simple Python class to access the JLR Remote Car API
https://github.com/ardevd/jlrpy
"""
import os
import warnings


import calendar
Expand Down Expand Up @@ -72,6 +74,12 @@ def __init__(self,
"grant_type": "refresh_token",
"refresh_token": refresh_token}
else:
warnings.warn(
"Password grant (ROPC) is deprecated per RFC 9700. "
"Use refresh_token authentication instead.",
DeprecationWarning,
stacklevel=2,
)
self.oauth = {
"grant_type": "password",
"username": email,
Expand Down Expand Up @@ -153,7 +161,7 @@ def _set_header(self, access_token):
"X-Device-Id": self.device_id,
"x-telematicsprogramtype": "jlrpy",
"x-App-Id": "ICR_JAGUAR_ANDROID",
"x-App-Secret": "7bf6f544-1926-4714-8066-ceceb40d538d",
"x-App-Secret": os.environ.get("JLR_APP_SECRET", "7bf6f544-1926-4714-8066-ceceb40d538d"),
"Content-Type": "application/json"}

def _authenticate(self, data=None):
Expand Down