Implement Directory Pagination and fix listing limits#19
Closed
jojomueller05 wants to merge 52 commits intoardean:masterfrom
Closed
Implement Directory Pagination and fix listing limits#19jojomueller05 wants to merge 52 commits intoardean:masterfrom
jojomueller05 wants to merge 52 commits intoardean:masterfrom
Conversation
Node 17+ openssl fix
Node 17 openssl fix
docs changes
Release workflow
* feature: basic readStream * fix: remove unneccesary return * fix: remove unused buffer variable * feature: createFileReadableStream on tree * feature: working read/write streams --------- Co-authored-by: Miguel Angel Cagide Fagin <miguelacfa@ext.inditex.com>
* feature: subchunks on writefilestream when chunk is bigger than "maxWriteChunkLength" fix: "close" event on readfilestream * chore: version bump, doc update
stop emit error on close
* stop emit error on close * version * fix: fixed subarray positions when chunk bigger than maxWriteChunkLength --------- Co-authored-by: Andy Wooldridge <99414101+awo00@users.noreply.github.com>
fix: remove miguel-cagide changes
fix: added missing new line
…-streams Feature: file read/write streams
Fix for error STATUS_USER_SESSION_DELETED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where directory listings were truncated because only the first batch of files was being returned. I have updated
src/client/Directory.tsto handle paginated responses from the SMB server.Changes:
Pagination Logic: Replaced the single
QueryDirectoryrequest inread()with awhileloop.Buffer Handling: Updated the request to use the wildcard
"*"only on the first call and an empty buffer for subsequent calls, as per SMB2 protocol requirements.Graceful Termination: Added a
try/catchblock to specifically handleSTATUS_NO_MORE_FILES(0x80000006), allowing the loop to exit cleanly when the end of the directory is reached.Code Formatting: Applied minor linting/formatting fixes (constructor shorthand and indentation) for better readability.
Related Issues
Fixes #9