Update GraphQL Upload by ardatan · Pull Request #8350 · ardatan/graphql-tools

ardatan · 2026-08-07T12:45:27Z

No description provided.

changeset-bot · 2026-08-07T12:45:31Z

⚠️ No Changeset found

Latest commit: b245c55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-08-07T12:45:34Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7823e7ec-de73-4264-a4dd-2aab1bc86fda

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe0319 and b245c55.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (8)

.github/dependabot.yml
packages/executor/package.json
packages/links/package.json
packages/loaders/url/package.json
patches/@0no-co+graphql.web+1.3.3.patch
patches/graphql-upload+18.0.0.patch
renovate.json
scripts/match-graphql.js

📝 Walkthrough

Summary by CodeRabbit

Bug Fixes
- Improved compatibility with the latest GraphQL upload tooling.
- Preserved upload validation and error handling across supported operations.
- Improved compatibility between GraphQL type definitions and current tooling.
Chores
- Updated project maintenance settings to better control automated package updates.
- Refined development environment cleanup and package version management.

Walkthrough

The pull request updates GraphQL-related dependencies and patches for compatibility, removes the executor’s GraphQL 17 development override, cleans up the matched GraphQL installation, and excludes selected packages from automated grouped updates.

Changes

GraphQL Compatibility Updates

Layer / File(s)	Summary
graphql-upload compatibility `packages/links/package.json`, `packages/loaders/url/package.json`, `patches/graphql-upload+18.0.0.patch`	Updates `graphql-upload` to `18.0.0`. The patch adds legacy scalar methods and changes GraphQL imports.
GraphQL types and executor cleanup `patches/@0no-co+graphql.web+1.3.3.patch`, `packages/executor/package.json`, `scripts/match-graphql.js`	Updates six constant AST aliases, removes the executor’s GraphQL development dependency, and removes the installed GraphQL module after matching.
Dependency update exclusions `.github/dependabot.yml`, `renovate.json`	Excludes `@babel/*` from grouped dependency updates. Renovate also excludes `sharp`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

ardatan/graphql-tools#8313: Follows up on GraphQL 17 support with related executor, graphql-upload, and compatibility patch changes.

Poem

A rabbit hops through GraphQL’s gate,
With patched AST types feeling great.
Uploads parse and serialize,
Old overrides retire,
While tidy updates wait.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch update-graphql-upload

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-07T12:48:28Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-tools/executor`	`2.0.0-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-apollo-link`	`2.0.13-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-envelop`	`4.0.13-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-legacy-ws`	`1.1.33-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-urql-exchange`	`1.0.35-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-yoga`	`3.0.43-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-tag-pluck`	`8.3.36-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`graphql-tools`	`9.0.34-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/import`	`7.1.19-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/links`	`10.0.13-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/load`	`8.1.16-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/apollo-engine-loader`	`8.0.35-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/code-file-loader`	`8.1.37-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/git-loader`	`8.0.41-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/github-loader`	`9.1.7-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-file-loader`	`8.1.19-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/json-file-loader`	`8.0.33-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/module-loader`	`8.0.33-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/url-loader`	`9.1.7-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/merge`	`9.2.3-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/mock`	`9.1.13-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/node-require`	`7.0.45-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/relay-operation-optimizer`	`7.1.9-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/resolvers-composition`	`7.0.36-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/schema`	`10.1.0-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎
`@graphql-tools/utils`	`12.0.0-alpha-20260807125822-b245c553f4da095050273ea1e79f9d4071543a0a`	npm ↗︎ unpkg ↗︎

github-actions · 2026-08-07T12:50:56Z

💻 Website Preview

The latest changes are available as preview in: https://pr-8350.graphql-tools-8ja.pages.dev

Copilot

Pull request overview

Updates the monorepo’s GraphQL upload tooling by bumping graphql-upload and applying patch-package fixes to keep dependencies working with the repo’s GraphQL setup and tooling automation.

Changes:

Bump graphql-upload to 18.0.0 in relevant workspaces and lockfile, and add a patch for its GraphQL scalar implementation.
Add a patch for @0no-co/graphql.web@1.3.3 typings to match the existing patch pattern used for 1.3.2.
Adjust automation/config: clean up a nested graphql install in packages/executor, and exclude @babel/* from Renovate/Dependabot update noise.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
scripts/match-graphql.js	Adds cleanup of `packages/executor/node_modules/graphql` during GraphQL version switching.
renovate.json	Excludes `@babel/*` packages from Renovate processing.
patches/graphql-upload+18.0.0.patch	Patch-package changes for `graphql-upload@18.0.0` (imports + scalar methods).
patches/@0no-co+graphql.web+1.3.3.patch	Patch-package typings update for `@0no-co/graphql.web@1.3.3`.
packages/loaders/url/package.json	Updates `graphql-upload` devDependency to `18.0.0`.
packages/links/package.json	Updates `graphql-upload` devDependency to `18.0.0`.
packages/executor/package.json	Removes `graphql` from `@graphql-tools/executor` devDependencies.
package-lock.json	Lockfile updates for `graphql-upload@18.0.0` (including engines/peer deps).
.github/dependabot.yml	Excludes `@babel/*` packages from Dependabot updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    "@types/apollo-upload-client": "19.0.0",
    "@types/node-fetch": "^2",
-    "graphql-upload": "17.1.0"
+    "graphql-upload": "18.0.0"


+@@ -2,8 +2,8 @@
+
+ /** @import { FileUpload } from "./processRequest.mjs" */
+
+-import { GraphQLError } from "graphql/error";
+-import { GraphQLScalarType } from "graphql/type";
+import { GraphQLError } from "graphql";
+import { GraphQLScalarType } from "graphql";
+
+ import Upload from "./Upload.mjs";


    "express": "5.2.1",
    "graphql-sse": "2.6.0",
-    "graphql-upload": "17.1.0",
+    "graphql-upload": "18.0.0",


+rmSync(resolve(cwd(), 'packages/executor/node_modules/graphql'), {
+  recursive: true,
+  force: true,
+});


ardatan added 2 commits August 7, 2026 15:43

Update GraphQL Upload

c9de4d3

Remove possible copies

45c5337

ardatan added 2 commits August 7, 2026 15:46

ignore babel

3a0de57

Ignore babel

9390cf3

github-actions Bot deployed to preview August 7, 2026 12:50 View deployment

Hmm

b245c55

github-actions Bot deployed to preview August 7, 2026 13:00 View deployment

ardatan marked this pull request as ready for review August 7, 2026 13:05

Copilot AI lite review requested due to automatic review settings August 7, 2026 13:05

ardatan merged commit 3a9c0f1 into master Aug 7, 2026
44 of 45 checks passed

ardatan deleted the update-graphql-upload branch August 7, 2026 13:05

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Navigation Menu

Uh oh!

Update GraphQL Upload - #8350

Update GraphQL Upload#8350
ardatan merged 5 commits into
masterfrom
update-graphql-upload

ardatan commented Aug 7, 2026

Uh oh!

changeset-bot Bot commented Aug 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 7, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ardatan commented Aug 7, 2026

Uh oh!

changeset-bot Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

github-actions Bot commented Aug 7, 2026

💻 Website Preview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Aug 7, 2026 •

edited

Loading

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading

github-actions Bot commented Aug 7, 2026 •

edited

Loading

🚀 Snapshot Release (`alpha`)