Repository navigation
fix(node): a related later emit waits behind an earlier held emit - #557
Merged
Merged
Conversation
Contributor
Author
|
审核结论:正确,可合并。 从根上修了: 小建议(可后续):事件协议 §5.5 的 Node 那句( |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ordering part of #546.
#runexecuted a related call (job.frame.pathcontains a waiting call id) even when an earlier emit of the same name was still queued and held by that wait. The later emit could therefore start first, violating §5.5. The queue is insertion-ordered, so#runnow leaves the job queued when an earlier job of the samekeyis still there; the existingfinally/microtask order runs them in emission order.Added a session test where the second emit is on the waiting chain; it would log
n:2, n:1without the fix.The close-time drop of queued local
behindwork (the second part of #546) is not changed here; it is a separate, narrower lifecycle question.