Repository navigation
docs(rfc-0045): one fix PR per vendor, one commit per difference - #348
Merged
Merged
Conversation
The behaviour differences found while porting a vendor's upstream tests go into a single fix PR for that vendor, each difference in its own commit with a test that fails on master, instead of one PR each. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RoxcKU4zBD64Lri3e4Lrq5
cunninghamcard-bit
marked this pull request as ready for review
October 24, 2026 11:34
eric8810
approved these changes
Oct 25, 2026
eric8810
left a comment
eric8810
left a comment
Contributor
There was a problem hiding this comment.
RFC-0045 的一行修改与当前批次一致，无阻塞。Approve。
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
改动前：RFC-0045 §5.4 第 4 条要求迁测试时发现的每处行为差异单独开一个 fix PR，Open Responses 一家就开了 16 个。
改动后：同一厂商的差异放进一个 fix PR，一处差异一个提交，每个提交带一个在 master 上失败的测试，描述里每处各写现状和改动两段调用栈；测试 PR 叠在这个 fix PR 上。其余不变（不在测试 PR 里修、登记到偏差清单、刻意差异记进
registered）。已经开的 fix PR 已按这条合并：Hugging Face #307、xAI #311、Anthropic AWS #318、OpenAI #323、Open Responses #346，其余的已关闭并在评论里指向保留的 PR；进度见 #278。
一、体系概览：迁测试时差异怎么处理（RFC-0045 §5.4）
二、本 PR 的改动
Type of change
Checklist
Generated by Claude Code