Repository navigation
Conversation
The two jobs #265 added ran on every pull request and were missing from CI result's needs, so a sanitizer failure did not block a merge. Gate them on the change map like rust-test and require them in CI result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0112xDERMUyD5JALkFhnsdWS
cunninghamcard-bit
marked this pull request as ready for review
October 20, 2026 10:39
eric8810
approved these changes
Oct 20, 2026
eric8810
left a comment
Contributor
There was a problem hiding this comment.
CI 逻辑检查
changes的 run map 新增ffi-sanitizers/ffi-linux-arm,两个 job 都补了needs: changes和对应if,ci-result也加入needs,整条链路一致。- 文档-only 和 bindings-only 的跳过路径符合预期:
shared覆盖共享 Rust 代码,aimux-ffi或scripts/test-c-abi.sh变更会触发两个 job。 - 未发现阻塞项。
Approve.
9 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by li · project thread
Before:
C ABI (ASan + LSan)andaimux-ffi (aarch64-unknown-linux-gnu), added in #265, ran on every pull request, documentation-only ones included, andCI result, the one check branch protection requires, did not wait for them. A pull request whose sanitizer run found a leak still showedCI resultgreen and could merge.After: both jobs run when the C ABI can change (
aimux-ffi/or shared Rust code), are skipped on documentation-only and binding-only pull requests, andCI resultfails when either of them fails.Changes
.github/workflows/ci.ymlonly (8 lines).How CI decides and reports today
CI resultonly sees the jobs in itsneeds. A job outside that list can fail without changing it, and a job withoutneeds: changes/if:runs on every pull request whatever it changes.What this pull request changes
Both jobs build
aimux-ffi, so they get the same rule asrust-test: they run when the C ABI or the shared Rust code it wraps changes (scripts/test-c-abi.shcounts as shared). Every job in the workflow is now in the run map and inCI result'sneeds.Checks
changesscript on test commits: aREADME.mdchange givesfalsefor both jobs; a change inaimux-ffi/src,aimux-core/srcorscripts/test-c-abi.shgivestrue; abindings/pythonchange givesfalsefor both andtrueforpython-binding.CI resultjq expression: a failedffi-sanitizersfails it; a skipped job whose run-map entry isfalsepasses.if:has an entry in the map, and every job exceptci-resultis in itsneeds.Generated by Claude Code