Repository navigation
[v4/p4-results] refactor(core)!: results, stream parts and the call pipeline follow the AI SDK - #238
Closed
cunninghamcard-bit wants to merge 1 commit into
Closed
cunninghamcard-bit wants to merge 1 commit into
cunninghamcard-bit wants to merge 1 commit into
Conversation
…ion as upstream does - Provider generate and stream results carry request and response information, as the upstream V4 result types do; raw is the provider result itself. - The response metadata stream part is absorbed into the finish step, and request and response are carried onto the call-layer results. - A tool-call repair applied to a result also updates the result's content. CHANGELOG records the result fields as breaking; the migration notes describe tool-call metadata on StreamingToolCallDelta. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A3WxDBWBA4ituJjXsHaEAa
4 of 12 tasks
6 tasks
cunninghamcard-bit
changed the title
9 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by li
Summary
Before: provider results do not carry request and response information, response metadata arrives as its own stream part, and applying a tool-call repair to a result leaves the result's content unchanged.
After: provider generate and stream results carry request and response as the upstream V4 result types do, and
rawis the provider result itself. Response metadata is absorbed into the finish step and carried onto the call-layer results. A tool-call repair also updates the result's content.This PR also takes the largest block of new work in the series (see below).
Type of change
Checklist
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepasses (cassette playback — no network/keys)README.md,docs/,rfc/,bindings/README.md)Notes for reviewers
Status: Draft, opened early so the series layout can be reviewed. The items under "Planned in follow-up pushes" land on this branch before it is marked ready.
cargo test --workspacehas not been run on this branch yet.textinstead ofdeltaon text and reasoning deltas; the 26 upstream stream parts; flatLanguageModelUsage;StepResult,steps,finalStep,output; response messages through an accumulator plusto_response_messages(includinginputSchemaInputon approval requests); mid-stream retries (streamRetries, default off); the first-chunk timer starting from the response stream; video polling.🤖 Generated with Claude Code
https://claude.ai/code/session_01A3WxDBWBA4ituJjXsHaEAa