Skip to content

test(providers): delete four hand-written test files the provider factories replace - #222

Closed
cunninghamcard-bit wants to merge 7 commits into
rfc-0036/provider-result-typesfrom
rfc-0036/factory-test-removal
Closed

cunninghamcard-bit wants to merge 7 commits into
rfc-0036/provider-result-typesfrom
rfc-0036/factory-test-removal

Conversation

@cunninghamcard-bit

@cunninghamcard-bit cunninghamcard-bit commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What

Removes the hand-written configuration, reasoning-map, transcription-stream and Node body-override test files before the provider factory migration. This branch follows provider-result-types and precedes upstream-samples in the stack split from #214. Its final diff only deletes test files; it does not change provider implementation or public types.

Before and after

Area Before After Upstream reference
Configuration snapshots Tests assert the existing registry construction and recorded configuration. aimux-providers/tests/config_snapshot_test.rs is deleted. @ai-sdk/openai/src/openai-provider.ts; factory changes follow on provider-factory-source.
Reasoning and request overrides Tests assert Rust registry profiles and request-body overrides. aimux-providers/tests/reasoning_map_test.rs is deleted. Provider request conversion modules under @ai-sdk/*/src; vendor alignment follows later.
Transcription streaming Tests exercise the Rust realtime WebSocket stream interface. aimux-providers/tests/openai_transcription_stream_test.rs is deleted. @ai-sdk/openai/src/transcription/openai-transcription-model.ts.
Node body overrides Tests exercise the Node-to-Rust HTTP path and existing factory configuration. bindings/node/__test__/body_overrides.test.ts is deleted. @ai-sdk/openai/src/openai-provider.ts; binding migration follows on provider-factory-source.

Tests

The final diff deletes only the four hand-written files above: git diff --shortstat rfc-0036/provider-result-types rfc-0036/factory-test-removal reports 4 files changed and 1,594 deletions. The upstream-ported provider test files remain in this branch. They are absent again on upstream-samples, then restored and migrated to the factory API on provider-factory-source. Cassette replays are kept, and neither cassettes nor fixtures change in this pull request. No replacement hand-written tests are added.

Not in this pull request

  • Provider factories and binding API migration belong to provider-factory-source, so production code can be reviewed separately from these deletions.
  • Sample files belong to upstream-samples; this branch does not introduce replay payloads.
  • The by-name entries in aimux_providers::provider used by FFI, Node and Python remain pending the maintainer's decision. Deleting configuration tests does not decide which construction entries remain public.

Stack refresh (2026-10-07)

Head 95ac2653 follows rfc-0036/provider-result-types at c16749d6. The stack includes master at 0b365b39 and the updated #203 (3e2d9fc7), #204 (b897cb21) and #213 (7c0933b1). Updated parents were merged into their children to preserve the existing public merge history; the PR base and Draft state are unchanged.

Verification

  • Relative to the updated immediate base: 4 files changed, 1594 deletions(-).
  • Rust formatting and workspace Clippy passed during this layer’s refresh. Final integration at local wire-format 415e37e1 passes cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, and the provider boundary script.
  • Full cargo test --workspace at final wire-format: 2,819 passed, 0 failed, 6 ignored, including doctests. The intermediate factory-source integration also passed 2,434 tests before the final obsolete Decision hook removal. These are integration results, not a claim that the full suite was rerun at every PR head.
  • Generated TypeScript synchronization, Node build:typed, and web production build passed at the wire-format layer.

Not verified

No GitHub check runs are attached to this Draft stack head at the time of this update. Go, Java, Kotlin, Swift and Flutter bindings were not compiled locally in this refresh; Node npm test and Python pytest were not run. Live vendor calls and unported upstream cases remain outside this validation.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS

chenhaonan and others added 7 commits October 6, 2026 15:38
… factories replace

What: removes four test files that assert Rust's own earlier behaviour
against a hand-written mock server: config_snapshot_test.rs,
reasoning_map_test.rs, openai_transcription_stream_test.rs and the Node
body_overrides test.

Why: first of four parts split out of the provider-factory pull request so
each can be reviewed alone. The factories that follow are covered by
tests ported from upstream; the project deletes hand-written tests of
this kind instead of rewriting them. Sixteen other test files in the
same directory are ports of the AI SDK's own tests and stay; the source
branch that changes the factory API migrates them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry up the stack the fixes made after the third independent
review on the branches below; this branch's code is converted to them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry up the stack the fixes made after the third independent
review on the branches below; this branch's code is converted to them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry up the stack the fixes made after the third independent
review on the branches below; this branch's code is converted to them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry the formatting commit up the stack; no code change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
@cunninghamcard-bit

Copy link
Copy Markdown
Contributor Author

Folded into #214 while consolidating the RFC-0036 stack from twelve pull requests into four. This branch is unchanged; its commits are part of the range #214 now shows (base rfc-0036/provider-result-types).

🤖 Generated with Claude Code

@cunninghamcard-bit
cunninghamcard-bit deleted the rfc-0036/factory-test-removal branch October 12, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant