Repository navigation
test(providers): delete four hand-written test files the provider factories replace - #222
Closed
cunninghamcard-bit wants to merge 7 commits into
Closed
cunninghamcard-bit wants to merge 7 commits into
cunninghamcard-bit wants to merge 7 commits into
Conversation
… factories replace What: removes four test files that assert Rust's own earlier behaviour against a hand-written mock server: config_snapshot_test.rs, reasoning_map_test.rs, openai_transcription_stream_test.rs and the Node body_overrides test. Why: first of four parts split out of the provider-factory pull request so each can be reviewed alone. The factories that follow are covered by tests ported from upstream; the project deletes hand-written tests of this kind instead of rewriting them. Sixteen other test files in the same directory are ports of the AI SDK's own tests and stay; the source branch that changes the factory API migrates them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry up the stack the fixes made after the third independent review on the branches below; this branch's code is converted to them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry up the stack the fixes made after the third independent review on the branches below; this branch's code is converted to them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry up the stack the fixes made after the third independent review on the branches below; this branch's code is converted to them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Why: carry the formatting commit up the stack; no code change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS
Contributor
Author
|
Folded into #214 while consolidating the RFC-0036 stack from twelve pull requests into four. This branch is unchanged; its commits are part of the range #214 now shows (base 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the hand-written configuration, reasoning-map, transcription-stream and Node body-override test files before the provider factory migration. This branch follows
provider-result-typesand precedesupstream-samplesin the stack split from #214. Its final diff only deletes test files; it does not change provider implementation or public types.Before and after
aimux-providers/tests/config_snapshot_test.rsis deleted.@ai-sdk/openai/src/openai-provider.ts; factory changes follow onprovider-factory-source.aimux-providers/tests/reasoning_map_test.rsis deleted.@ai-sdk/*/src; vendor alignment follows later.aimux-providers/tests/openai_transcription_stream_test.rsis deleted.@ai-sdk/openai/src/transcription/openai-transcription-model.ts.bindings/node/__test__/body_overrides.test.tsis deleted.@ai-sdk/openai/src/openai-provider.ts; binding migration follows onprovider-factory-source.Tests
The final diff deletes only the four hand-written files above:
git diff --shortstat rfc-0036/provider-result-types rfc-0036/factory-test-removalreports 4 files changed and 1,594 deletions. The upstream-ported provider test files remain in this branch. They are absent again onupstream-samples, then restored and migrated to the factory API onprovider-factory-source. Cassette replays are kept, and neither cassettes nor fixtures change in this pull request. No replacement hand-written tests are added.Not in this pull request
provider-factory-source, so production code can be reviewed separately from these deletions.upstream-samples; this branch does not introduce replay payloads.aimux_providers::providerused by FFI, Node and Python remain pending the maintainer's decision. Deleting configuration tests does not decide which construction entries remain public.Stack refresh (2026-10-07)
Head
95ac2653followsrfc-0036/provider-result-typesatc16749d6. The stack includesmasterat0b365b39and the updated #203 (3e2d9fc7), #204 (b897cb21) and #213 (7c0933b1). Updated parents were merged into their children to preserve the existing public merge history; the PR base and Draft state are unchanged.Verification
wire-format415e37e1passescargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, and the provider boundary script.cargo test --workspaceat finalwire-format: 2,819 passed, 0 failed, 6 ignored, including doctests. The intermediate factory-source integration also passed 2,434 tests before the final obsolete Decision hook removal. These are integration results, not a claim that the full suite was rerun at every PR head.build:typed, and web production build passed at the wire-format layer.Not verified
No GitHub check runs are attached to this Draft stack head at the time of this update. Go, Java, Kotlin, Swift and Flutter bindings were not compiled locally in this refresh; Node
npm testand Pythonpytestwere not run. Live vendor calls and unported upstream cases remain outside this validation.🤖 Generated with Claude Code
https://claude.ai/code/session_01WGwanvo9WLU9HWD7sRR8TS