Skip to content

fix: handle new map Instruction variants in wit-bindgen-core 0.56 (supersedes #190) #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcjet-rei merged 2 commits into from
Apr 21, 2026
Merged

fix: handle new map Instruction variants in wit-bindgen-core 0.56 (supersedes #190) #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3599db
chore(deps): Bump the wit group across 1 directory with 3 updates
dependabot[bot] Apr 20, 2026
05ec8cf
fix: handle new Instruction variants introduced by wit-bindgen-core 0.56
arcjet-rei Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions cmd/gravity/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ test = false
[dependencies]
clap = "=4.6.1"
genco = "=0.19.0"
wit-bindgen-core = "=0.53.1"
wit-component = "=0.245.1"
wit-bindgen-core = "=0.56.0"
wit-component = "=0.246.2"

[dev-dependencies]
# Cutting out `filesystem` feature
trycmd = { version = "=1.2.0", default-features = false, features = [
"color-auto",
"diff",
] }
wit-bindgen = "=0.53.1"
wit-bindgen = "=0.56.0"
7 changes: 7 additions & 0 deletions cmd/gravity/src/codegen/func.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,9 +1410,16 @@ impl Bindgen for Func<'_> {
Instruction::GuestDeallocateString
| Instruction::GuestDeallocate { .. }
| Instruction::GuestDeallocateList { .. }
| Instruction::GuestDeallocateMap { .. }
| Instruction::GuestDeallocateVariant { .. } => {
unimplemented!("gravity doesn't generate the Guest code")
}
Instruction::MapLower { .. }
| Instruction::MapLift { .. }
| Instruction::IterMapKey { .. }
| Instruction::IterMapValue { .. } => {
todo!("implement instruction: {inst:?}")
}
Instruction::FutureLower { .. } => todo!("implement instruction: {inst:?}"),
Instruction::FutureLift { .. } => todo!("implement instruction: {inst:?}"),
Instruction::StreamLower { .. } => todo!("implement instruction: {inst:?}"),
Expand Down
4 changes: 2 additions & 2 deletions examples/basic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ edition = "2024"
crate-type = ["cdylib"]

[dependencies]
wit-bindgen = "=0.53.1"
wit-component = "=0.245.1"
wit-bindgen = "=0.56.0"
wit-component = "=0.246.2"
4 changes: 2 additions & 2 deletions examples/iface-method-returns-string/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ edition = "2024"
crate-type = ["cdylib"]

[dependencies]
wit-bindgen = "0.53.1"
wit-component = "0.245.1"
wit-bindgen = "0.56.0"
wit-component = "0.246.2"
4 changes: 2 additions & 2 deletions examples/instructions/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ edition = "2024"
crate-type = ["cdylib"]

[dependencies]
wit-bindgen = "=0.53.1"
wit-component = "=0.245.1"
wit-bindgen = "=0.56.0"
wit-component = "=0.246.2"
4 changes: 2 additions & 2 deletions examples/records/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ edition = "2024"
crate-type = ["cdylib"]

[dependencies]
wit-bindgen = "=0.53.1"
wit-component = "=0.245.1"
wit-bindgen = "=0.56.0"
wit-component = "=0.246.2"
4 changes: 2 additions & 2 deletions examples/regressions/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ edition = "2024"
crate-type = ["cdylib"]

[dependencies]
wit-bindgen = "=0.53.1"
wit-component = "=0.245.1"
wit-bindgen = "=0.56.0"
wit-component = "=0.246.2"