Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Arcjet Review — 🟢 Low Risk
Decision: Approved
Rationale: Small, well-scoped fix to the framework switcher plus three patch-level dependency bumps and a pnpm override refactor. The switcher now validates input via isValidFrameworkKey before storing, and a new getInitialFramework() bootstraps the store from query param or stored preference with a proper SSR guard (typeof window === 'undefined'). The query param value is validated before being cast to FrameworkKey and before being written back to the URL, so there is no injection/XSS surface. Dependency bumps (@clerk/nextjs 6.39.0→6.39.2, hono 4.12.12→4.12.14, fastify 5.8.4→5.8.5) are patch releases. The dependency-changes trigger fires but the updates are minimal; I'm approving with Low risk.
Summary of Changes
Fixes the framework switcher by validating the selected key up-front, persisting it, and doing a full page reload with the new f query param instead of a pushState + in-memory store update. Adds getInitialFramework() in store.ts to seed the nanostore from the URL param or stored preference on client init (SSR-safe). Also bumps @clerk/nextjs, hono, and fastify to patch versions, and replaces a nested vite-node>vite pnpm override with a top-level vite override.
Escalation Triggers
- Dependency Changes: package.json and snippets/fastify/package.json updated — @clerk/nextjs, hono, fastify patch bumps and a pnpm overrides change for vite.
Notes
PR size is well under the 1000-line threshold. lib/prefs was not included in the diff — the review assumes isValidFrameworkKey and getStoredFramework already exist and behave as the new call sites expect.
Path filtering: 1 file excluded by ignore paths. 4 of 5 files included in review.
Review: 3b5ff3bc | Powered by Arcjet Review
Simplifies framework switching logic to ensure full page gets updated.
Fixed some dependency warnings and notices as well.