Conversation
Fixes environment's PATH being empty, thus being useless when SSH-ing into machines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes environment's PATH being empty, thus being useless when SSH-ing into machines
Description
When manually SSH-ing into my Archcraft machine, it connects with a session. However, using Visual Studio Code's Remote-SSH, it initially SSH-es into the machine headless. With
/etc/environment's PATH not pointing to the system binaries, it could do nothing and would fail. Adding paths to system binaries restores headless SSH functionality.Fixes #455
Type of change
Please delete options that are not relevant.
User Impact
Fixes headless SSH sessions into Archcraft machines.
Performance Impact
None
How Has This Been Tested?
I have tested this on my local machine running the latest version of Archcraft.
I could not use Visual Studio Code's Remote-SSH because it uses headless SSH to set up the remote server, which would fail because it could not find expected system binaries. Using this PATH value fixes this issue completely. I have confirmed this also fixed the same issue on a friend's machine running a clean install of Archcraft.
Software Configuration:
Checklist: