chore(release): curate the 1.35.0 highlights - #389
Closed
KafuChino123 wants to merge 1 commit into
Closed
Conversation
The 1.35.0 release PR merged with an empty `### Highlights` section, so `cargo xtask release notes` now fails on every PR against master. That step runs before Lint, Build and Test, so no PR gets as far as compiling. The release DMG extracts the same section to feed Sparkle's update dialog and refuses to build without it, so 1.35.0 cannot be packaged either. Write the section from what 1.35.0 actually shipped: the Fleet device auth, enrollment and runner management in #320, the authoritative sandbox port reconciliation in #374, and the telemetry identification and Privacy toggle ordering in #367.
Greptile SummaryAdds the missing user-facing Highlights section for release 1.35.0, restoring the release-note extraction required by CI and packaging.
Confidence Score: 5/5The PR appears safe to merge, with the added highlights accurately describing the shipped release behavior. The changelog now contains the non-empty Highlights section required by release tooling, and its user-facing claims align with the implemented features.
|
| Filename | Overview |
|---|---|
| CHANGELOG.md | Adds release highlights consistent with the shipped runner, sandbox-port, and analytics behavior; no actionable issues identified. |
Reviews (1): Last reviewed commit: "chore(release): curate the 1.35.0 highli..." | Re-trigger Greptile
Member
Author
|
Superseded by #386 — the same commit now lives on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every PR against
mastercurrently fails CI before it compiles.Release PR #382 (
chore(master): release 1.35.0,4e034ec) merged with its own check already red, leaving## [1.35.0]inCHANGELOG.mdwithout a### Highlightssection while.release-please-manifest.jsonnames1.35.0. So pr.yml:90 fails:That step sits ahead of
Lint,Create local Xcode config,Build (Debug)andRun Tests, all of which are skipped when it fails.release-please--branches--masterrelease-please--branches--mastermaster(post-merge)fix/detail-tab-glass-animationBranches from earlier the same day passed — they predate the merge. Tag
v1.35.0already exists, so this cannot be fixed by amending the release PR.The blast radius is wider than CI: pr.yml:84-87 notes the release DMG extracts this same section to feed Sparkle's update dialog and refuses to build without it, so 1.35.0 cannot be packaged either.
Change
Adds the missing
### Highlightsblock, written from what 1.35.0 actually shipped:Build, docs and CI-only entries are left out — this text is what users see in the update dialog.
Verification
cargo xtask release notes --version "$(jq -r '."."' .release-please-manifest.json)"— the exact CI invocation — now succeeds and extracts:Note for reviewers
The wording is the part worth reviewing, not the mechanics — this ships verbatim to users in Sparkle's update dialog.
One sentence is a deliberate judgment call: the telemetry line states plainly that a signed-in account is identified by email and name while analytics is on. #367 made that change and also corrected the Privacy toggle's caption, which had claimed no personal data was collected. Being upfront in the release notes seemed consistent with that, but reword or drop it if you'd rather it not appear there.
Once this merges, other open PRs only need their checks re-run —
actions/checkout@v6builds the head-merged-into-base commit, so no rebase is required.