Skip to content

chore(release): curate the 1.35.0 highlights - #389

Closed
KafuChino123 wants to merge 1 commit into
masterfrom
chore/release-1-35-0-highlights
Closed

chore(release): curate the 1.35.0 highlights#389
KafuChino123 wants to merge 1 commit into
masterfrom
chore/release-1-35-0-highlights

Conversation

@KafuChino123

Copy link
Copy Markdown
Member

Problem

Every PR against master currently fails CI before it compiles.

Release PR #382 (chore(master): release 1.35.0, 4e034ec) merged with its own check already red, leaving ## [1.35.0] in CHANGELOG.md without a ### Highlights section while .release-please-manifest.json names 1.35.0. So pr.yml:90 fails:

Error: release 1.35.0 has no non-empty ### Highlights section

That step sits ahead of Lint, Create local Xcode config, Build (Debug) and Run Tests, all of which are skipped when it fails.

Time (UTC) Branch Result
10:37 release-please--branches--master failure
10:40 release-please--branches--master failure
10:41 master (post-merge) failure
13:44 fix/detail-tab-glass-animation failure

Branches from earlier the same day passed — they predate the merge. Tag v1.35.0 already exists, so this cannot be fixed by amending the release PR.

The blast radius is wider than CI: pr.yml:84-87 notes the release DMG extracts this same section to feed Sparkle's update dialog and refuses to build without it, so 1.35.0 cannot be packaged either.

Change

Adds the missing ### Highlights block, written from what 1.35.0 actually shipped:

Build, docs and CI-only entries are left out — this text is what users see in the update dialog.

Verification

cargo xtask release notes --version "$(jq -r '."."' .release-please-manifest.json)" — the exact CI invocation — now succeeds and extracts:

Runners arrive: sign in, enroll this Mac as a Fleet device, and manage its runners from the new Runners section, which stays current as agent state changes instead of waiting for a refresh.

The Sandboxes Ports tab now reflects the daemon's own record of exposed ports, so mappings made from the CLI or SDK show up, stale rows clear themselves, and Refresh is there when you want to re-check. Analytics also honours the Privacy toggle more faithfully: while it is on, a signed-in account is identified by email and name, and switching it back on after signing in no longer leaves the session anonymous.

Note for reviewers

The wording is the part worth reviewing, not the mechanics — this ships verbatim to users in Sparkle's update dialog.

One sentence is a deliberate judgment call: the telemetry line states plainly that a signed-in account is identified by email and name while analytics is on. #367 made that change and also corrected the Privacy toggle's caption, which had claimed no personal data was collected. Being upfront in the release notes seemed consistent with that, but reword or drop it if you'd rather it not appear there.

Once this merges, other open PRs only need their checks re-run — actions/checkout@v6 builds the head-merged-into-base commit, so no rebase is required.

The 1.35.0 release PR merged with an empty `### Highlights` section, so
`cargo xtask release notes` now fails on every PR against master. That
step runs before Lint, Build and Test, so no PR gets as far as
compiling. The release DMG extracts the same section to feed Sparkle's
update dialog and refuses to build without it, so 1.35.0 cannot be
packaged either.

Write the section from what 1.35.0 actually shipped: the Fleet device
auth, enrollment and runner management in #320, the authoritative
sandbox port reconciliation in #374, and the telemetry identification
and Privacy toggle ordering in #367.
@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown

Greptile Summary

Adds the missing user-facing Highlights section for release 1.35.0, restoring the release-note extraction required by CI and packaging.

  • Highlights Fleet enrollment and live runner management.
  • Describes daemon-authoritative sandbox port reconciliation.
  • Explains analytics identity and Privacy-toggle behavior.

Confidence Score: 5/5

The PR appears safe to merge, with the added highlights accurately describing the shipped release behavior.

The changelog now contains the non-empty Highlights section required by release tooling, and its user-facing claims align with the implemented features.

Important Files Changed

Filename Overview
CHANGELOG.md Adds release highlights consistent with the shipped runner, sandbox-port, and analytics behavior; no actionable issues identified.

Reviews (1): Last reviewed commit: "chore(release): curate the 1.35.0 highli..." | Re-trigger Greptile

@KafuChino123

Copy link
Copy Markdown
Member Author

Superseded by #386 — the same commit now lives on fix/detail-tab-glass-animation so the changelog fix and the tab picker fix land together. Closing to avoid two PRs carrying the same change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant