-
Notifications
You must be signed in to change notification settings - Fork 58
Support Spring boot 4 #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Benjamin Schwertfeger.
|
src/test/java/com/arangodb/springframework/core/template/ArangoIndexTest.java
Outdated
Show resolved
Hide resolved
9a65983 to
44d1401
Compare
|
Fresh avocado detected! Welcome and thank you for your contribution @bschwert. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/test/java/com/arangodb/springframework/core/template/ArangoIndexTest.java
Outdated
Show resolved
Hide resolved
44d1401 to
cfa95cc
Compare
|
Fresh avocado detected! Welcome and thank you for your contribution @bschwert. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues. |
cfa95cc to
518fc48
Compare
|
Fresh avocado detected! Welcome and thank you for your contribution @bschwert. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues. |
|
CLA has been received |
|
@rashtao CLA available |
518fc48 to
c896c7f
Compare
With Spring Boot 4 many dependencies got updated and namespaces changed. I'ld like to have the spring-data integration available for spring boot 4.
There is an issue regarding spring boot 4 already: #335
Note
Medium Risk
This is a major dependency upgrade (Spring Boot/Spring Data) with API signature changes and altered validation timing, which can affect repository/query behavior and mapping errors at runtime.
Overview
Upgrades the project to Spring Boot 4 / Spring Data Commons 4.0 by bumping the module version to
5.0.0-SNAPSHOT, updating thespring-data-parentto4.0.0, and refreshing build tooling (notablymaven-resources-plugin).Aligns code with Spring Data 4.0 namespace/API changes by switching
TypeInformation/PropertyPathimports to their new packages and updatingArangoRepositoryFactory#getQueryLookupStrategyto useValueExpressionDelegateinstead ofQueryMethodEvaluationContextProvider.Adjusts tests for Spring Data 4.0 behavior: marks the base integration test context as dirty to prevent parallel DB teardown conflicts, and relaxes the TTL-index validation assertion to handle wrapped
MappingExceptions caused by earlier entity validation.Written by Cursor Bugbot for commit c896c7f. This will update automatically on new commits. Configure here.