Repository navigation
mlconfig: fix crash in width buttons on the font tab - #182
Merged
arakiken merged 1 commit intoOct 18, 2026
Merged
Conversation
specify_width() located the ':<percent>' suffix with cp = strrchr(fontname, ':') but then parsed it with atoi(p + 1), where p is still uninitialized at that point. Pressing the widen/narrow/default width buttons with a font name containing ':' crashed mlconfig (segfault at address 1 inside strtol when p happened to be NULL). Parse from cp instead.
Owner
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a segmentation fault in
mlconfigwhen clicking font width buttons (widen/narrow/default) for font names that contain a:character.Cause of Bug
In
specify_width(), the:<percent>suffix was located usingcp = strrchr(fontname, ':'), but it was parsed usingatoi(p + 1). At that point in execution,pwas uninitialized (oftenNULL).When a font name contained
:, pressing any of the width buttons passedp = NULLtoatoi(), leading to a crash (segfault at address 1insidestrtol).Fix
Changed the parser to parse the ratio from
cpinstead of the uninitialized pointerp.