Repository navigation
Fix linking libmef for input method plugins - #181
Merged
Merged
Conversation
Owner
|
Thanks you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link input method plugins (
uim,ibus,fcitx,m17nlib,scim, andcanna) withlibmef.Reason for Change
The
uim,ibus,fcitx,m17nlib,scim, andcannaplugins useef_*functions fromlibmef(e.g. viaim_convert_encoding()ininputmethod/im_common.h) but do not link against it, unlikekbd/skk/wnn/iiimfwhich have@LMEF@.Inside
mltermthis goes unnoticed becauselibmefis already loaded. However,mlconfigcallsdlopen()on the plugins to queryim_*_get_info()withoutlibmef. When built withBIND_NOW(hardening=+all), thedlopenfails due to the unresolved symbol (ef_bytes_to_int), causing the plugins to silently disappear frommlconfig's input method list.Impact
This change ensures that all input method plugins properly link against
libmef, allowingmlconfigto load them correctly even under strict hardening flags (BIND_NOW).Screenshot
Before / After