palakurthi-leblanc submission#3
Conversation
araiho
left a comment
araiho
left a comment
There was a problem hiding this comment.
3.8/4 good job but it was hard for me to tell what I was supposed to be grading because there were multiple files for the same answer. Make sure to only have one set of answers to each question.
| value2=96.4776 | ||
| v=value1-value2 | ||
| p=0 | ||
| >>>>>>> 9cf11ca599d407d6eb4bd775a40442e4c1891c8c |
There was a problem hiding this comment.
make sure you delete the merge conflict marks
| @@ -0,0 +1,66 @@ | |||
| rm(list=ls()) | |||
There was a problem hiding this comment.
I'm confused if I should be looking at this or the other scripts? Make sure to keep your answers in the same file and trade that back and forth instead of creating separate files. Version control is meant to keep track of the same set of files not multiple sets of files doing the same thing. Does that make sense?
| fit=optim(par=initialGuess,fn=nllike,x=WT,y=V456D) | ||
| # value=0 | ||
|
|
||
| nllike<-function(p,x,y){ |
There was a problem hiding this comment.
Your functions are a little confusing to me because they all have the same name. Make sure to name functions differently and to have informative names.
|
|
||
| initialGuess=c(1,1,1,1) | ||
| fit=optim(par=initialGuess,fn=nllike,x=WT,y=I213N) | ||
| nll2=73.96622 |
There was a problem hiding this comment.
hardcoding numbers like this is error prone because if you rerun your analysis you will need to change these hardcoded numbers and you may forget causing errors in your final output. use something like fit[1] - fit[2] next time.
| @@ -0,0 +1,51 @@ | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Make sure to remove merge conflict text! Your script should be able to run all the way through without any errors and this would certainty cause an error.
3 participants
No description provided.