Palakurthi_LeBlanc _submission#2
Open
bpalakur wants to merge 6 commits into
Open
Conversation
araiho
reviewed
Dec 7, 2017
araiho
left a comment
araiho
left a comment
Owner
There was a problem hiding this comment.
good job! 4/4 but next time work on for loops to make the code less confusing and more efficient. and for the project it'll be important that it's very clear which code is meant to answer the questions. This submission has a few answers for the same question which is confusing.
|
|
||
| #Repeat the same with different values of r | ||
|
|
||
| ddSim<-function(t,y,p){ |
Owner
There was a problem hiding this comment.
You do not need to define a same function more than once in a script
| times=1:100 | ||
| modelSim=ode(y=N0,times=times,func=ddSim,parms=params) | ||
| modelOutput33=data.frame(time=modelSim[,1],N=modelSim[,2]) | ||
|
|
Owner
There was a problem hiding this comment.
This can get pretty confusing. Next time try a for loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.