starting to bring to new version of ghc#30
Open
andrewufrank wants to merge 2 commits intoarademaker:masterfrom
Open
starting to bring to new version of ghc#30andrewufrank wants to merge 2 commits intoarademaker:masterfrom
andrewufrank wants to merge 2 commits intoarademaker:masterfrom
Conversation
added 2 commits
April 13, 2019 13:22
for 7.0 all but one error fixed (Char not [Char])
Author
|
I fixed some trivial errors (using the instruction of the changelog of megaparsec 7.0 as instructions) but I could not fix the last error. |
Collaborator
|
hi @andrewufrank, thanks for this! I've incorporated your changes into a new PR and updated a few small things to get megaparsec to work again. can you test and see if there's any change in behaviour? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to bring the package to a more current ghc (8.6.4) with lts-13.12 but found a number of errors, mostly with regards to Megaparsec and error handling - which I do not understand very well.
Could you try to fix them? Thank you!