Conversation
… (v3.2.13) - killall plasmashell → killall -u "$USER" plasmashell so it cannot accidentally kill plasmashell sessions belonging to other users on multi-user systems - String != comparisons for controller count changed to -ne (numeric) - String = comparison for CURRENT_PLAYER_COUNT=3 changed to -eq (numeric) All other peer-review findings were confirmed false positives: - Unquoted $LAUNCHER_EXEC is intentional word splitting (flatpak run …) - $- flag save/restore pattern is correct - sed delimiter choice is safe for all actual values substituted - Dependency ID validation threshold is correct for Modrinth 8-char IDs https://claude.ai/code/session_0156HqbWenksACpkAbh83nix
- .github/workflows/shellcheck.yml: runs shellcheck --severity=error on
all *.sh files for every PR and push to main; provides the status check
that branch protection requires before merge
- .github/setup-rulesets.sh: one-shot script (needs GITHUB_TOKEN with
repo scope) that configures:
1. Classic main branch protection — require PR + 1 approval, dismiss
stale reviews, resolve conversations, linear history, no force-push
2. Branch naming ruleset — feat/* fix/* chore/* docs/* refactor/*
claude/* hotfix/* test/* patterns enforced on non-main branches
3. Conventional commit ruleset — commits landing on main must match
^(feat|fix|chore|docs|...) prefix pattern
https://claude.ai/code/session_0156HqbWenksACpkAbh83nix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CURRENT_PLAYER_COUNTwas being assigned afterupdatePlaceholderWindow()in the scale-up path ofhandleControllerChange. When a 3rd player joined, the check insideupdatePlaceholderWindowsaw the stale old count (2) and calledhidePlaceholderWindowinstead ofshowPlaceholderWindow. Fixed by moving the assignment before the call.guiScale:0(auto-detect) in the generatedoptions.txtpicks a tiny scale for quarter-screen windows. Changed toguiScale:4(maximum) so HUD elements stay readable from 16+ feet away.killallscoped to current user:killall plasmashell→killall -u "$USER" plasmashellto prevent accidentally killing other users' desktop shell on multi-user systems.!=/=) to numeric (-ne/-eq).Test plan
killall plasmashellfallback path (Desktop Mode, non-KWin)https://claude.ai/code/session_0156HqbWenksACpkAbh83nix