Fix: Wireshark crashes when using "important" filter - #68
Merged
Conversation
The important filter assumes parse-arguments is enabled in tracee, and filters by the parsed value of the ptrace event's request field. If parse-arguments is disabled, the field is an int which causes some sort of confusion with the explicitly registered request field (defined as a string), which causes Wireshark to crash when applying a filter that compares the field's value with a string. This commit overrides the field type of the request, and adds a new enriched field to the event, which contains the parsed request. The "important" filter now uses this parsed field instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important filter assumes parse-arguments is enabled in tracee, and filters by the parsed value of the ptrace event's request field. If parse-arguments is disabled, the field is an int which causes some sort of confusion with the explicitly registered request field (defined as a string), which causes Wireshark to crash when applying a filter that compares the field's value with a string.
This commit overrides the field type of the request, and adds a new enriched field to the event, which contains the parsed request. The "important" filter now uses this parsed field instead.