Skip to content

fix: libro kernel shutdown #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HellowVirgil merged 1 commit into from
Jan 27, 2026
+2 −4
Merged

fix: libro kernel shutdown #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/libro-jupyter/src/cell/jupyter-code-cell-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ export class JupyterCodeCellView extends LibroCodeCellView {
}
(cellModel.metadata.execution as any)['libro_execution_msg_id'] =
future.msg.header.msg_id;
// 触发保存
this.parent.model.saveNotebookContent();
cellModel.metadata = { ...cellModel.metadata };

// Handle iopub messages
future.onIOPub = (msg: any) => {
Expand All @@ -222,8 +221,7 @@ export class JupyterCodeCellView extends LibroCodeCellView {
to_execute: new Date().toISOString(),
libro_execution_msg_id: future.msg.header.msg_id,
} as ExecutionMeta;
// 触发保存
this.parent.model.saveNotebookContent();
cellModel.metadata = { ...cellModel.metadata };
cellModel.kernelExecuting = true;
startTimeStr = msg.header.date as string;
const meta = cellModel.metadata.execution as ExecutionMeta;
Expand Down
Loading