-
Notifications
You must be signed in to change notification settings - Fork 298
docs: update output dir for tanstack start #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates two occurrences in the TanStack Start Appwrite Sites quick-start documentation to make the output directory conditional: use Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/routes/docs/products/sites/quick-start/tanstack-start/+page.markdoc
Outdated
Show resolved
Hide resolved
src/routes/docs/products/sites/quick-start/tanstack-start/+page.markdoc
Outdated
Show resolved
Hide resolved
|
Bypassing CI/CD test failure rule, seems to work localy. |
|
@elylucas Thanks for the amazing PR 🥳 Really appreciate the contribution to open source 🙌 |
What does this PR do?
Updates the Tanstack start guide to have the correct output directory
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Fixes #2681
Have you read the Contributing Guidelines on issues?
Yes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.