Skip to content

Conversation

@elylucas
Copy link
Contributor

@elylucas elylucas commented Jan 1, 2026

What does this PR do?

Updates the Tanstack start guide to have the correct output directory

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Fixes #2681

Have you read the Contributing Guidelines on issues?

Yes

Summary by CodeRabbit

  • Documentation
    • Clarified TanStack Start Appwrite Sites deployment guidance: output directory is conditional — use ./.output when using Nitro v2 or v3, otherwise continue using ./dist.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026

Walkthrough

This pull request updates two occurrences in the TanStack Start Appwrite Sites quick-start documentation to make the output directory conditional: use ./.output when Nitro v2 or v3 is in use, otherwise use ./dist. No other steps, logic, structural changes, or exported entities were modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—updating documentation for the TanStack Start output directory configuration.
Linked Issues check ✅ Passed The PR updates the output directory guidance from ./dist to a conditional note based on Nitro version, directly addressing issue #2681's requirement to specify the correct output directory.
Out of Scope Changes check ✅ Passed All changes are scoped to updating the TanStack Start output directory documentation as required by issue #2681; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 763ebbe and 959e7f3.

📒 Files selected for processing (1)
  • src/routes/docs/products/sites/quick-start/tanstack-start/+page.markdoc
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/routes/docs/products/sites/quick-start/tanstack-start/+page.markdoc
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: assets
  • GitHub Check: build
  • GitHub Check: tests

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fac10b and 9e9673d.

📒 Files selected for processing (1)
  • src/routes/docs/products/sites/quick-start/tanstack-start/+page.markdoc

@Meldiron
Copy link
Contributor

Bypassing CI/CD test failure rule, seems to work localy.

@Meldiron Meldiron merged commit 6a1ab4c into appwrite:main Jan 16, 2026
7 of 11 checks passed
@Meldiron
Copy link
Contributor

@elylucas Thanks for the amazing PR 🥳 Really appreciate the contribution to open source 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tanstack start guide has wrong output directory

3 participants