Release: v10.0.45

CR.Exceptions.AspNet.Tests/Component/CrExceptionHandlerTests.cs

@@ -20,11 +20,11 @@ public CrExceptionHandlerTests(ITestOutputHelper output)
     }
 
     [Fact]
-    public Task Should_Return_500_For_InternalException()
+    public Task Should_Return_404_For_NotFoundException()
     {
         return AssertHandlerResult(
-            new TestInternalException(),
-            StatusCodes.Status500InternalServerError,
+            new TestNotFoundException(),
+            StatusCodes.Status404NotFound,
             canCreateActivity: true);
     }
 
@@ -66,7 +66,7 @@ private async Task AssertHandlerResult(Exception exception, int expectedStatusCo
         var problem = await JsonSerializer.DeserializeAsync<TestProblemDetails>(responseStream, JsonSerializerOptions.Web);
         var expectedTraceId = activity?.TraceId.ToHexString() ?? context.TraceIdentifier;
 
-        AssertProblemDetails(problem, context, expectedStatusCode, expectedTraceId);
+        AssertProblemDetails(problem, expectedStatusCode, expectedTraceId);
 
         _output.WriteLine(JsonSerializer.Serialize(problem, options: _prettyJsonOptions));
     }
@@ -77,16 +77,14 @@ private static void AssertHttpContext(HttpContext context, int expectedStatusCod
         Assert.Contains("application/problem+json", context.Response.ContentType);
     }
 
-    private static void AssertProblemDetails(TestProblemDetails? problem, HttpContext context, int expectedStatusCode, string? expectedTraceId)
+    private static void AssertProblemDetails(TestProblemDetails? problem, int expectedStatusCode, string? expectedTraceId)
     {
         Assert.NotNull(problem);
 
         Assert.False(string.IsNullOrEmpty(problem.Type));
         Assert.False(string.IsNullOrEmpty(problem.Title));
-        Assert.False(string.IsNullOrEmpty(problem.Detail));
 
         Assert.Equal(expectedStatusCode, problem.Status);
-        Assert.Equal(context.Request.Path, problem.Instance);
 
         Assert.True(problem.Extensions.TryGetValue(ProblemDetailsExtensionNames.TraceId, out var traceId));
         Assert.Equal(expectedTraceId, traceId!.ToString());
@@ -105,9 +103,8 @@ private static ServiceProvider CreateServiceProvider()
 
     private static DefaultHttpContext CreateContext(MemoryStream responseStream)
     {
-        return new DefaultHttpContext
+        return new()
         {
-            Request = { Path = "/api/test" },
             Response = { Body = responseStream }
         };
     }

CR.Exceptions.AspNet/CrExceptionHandler.cs

@@ -38,16 +38,14 @@ public async ValueTask<bool> TryHandleAsync(HttpContext httpContext, Exception e
             return false;
         }
 
+        var errors = DefaultInternalErrors;
         var statusCode = StatusCodes.Status500InternalServerError;
+
         var exceptionType = exception.GetType();
         var exceptionTypeName = exceptionType.FullName ?? exceptionType.Name;
 
-        var errors = DefaultInternalErrors;
-        var detail = "An unexpected error occurred.";
-
         if (exception is CrException crException)
         {
-            detail = crException.Message;
             errors = crException.Errors;
 
             if (_statusCodeMap.TryFind(crException, out var code))
@@ -78,12 +76,7 @@ public async ValueTask<bool> TryHandleAsync(HttpContext httpContext, Exception e
         {
             HttpContext = httpContext,
             Exception = exception,
-            ProblemDetails =
-            {
-                Status = statusCode,
-                Detail = detail,
-                Instance = httpContext.Request.Path
-            },
+            ProblemDetails = { Status = statusCode, },
         };
 
         AddProblemDetailsExtension(problemDetailsContext.ProblemDetails, ProblemDetailsExtensionNames.Errors, errors);

CR.Exceptions.AspNet/README.md

@@ -16,12 +16,6 @@ This package provides automatic handling of `CrException` instances, converts th
 
 # Installation
 
-```bash
-dotnet add package CrCore.Exceptions.AspNet
-```
-
-Register the default exception handling during application startup.
-
 ```csharp
 builder.Services.AddCrExceptionsCore();
 
@@ -88,18 +82,16 @@ Example:
 
 ```json
 {
-  "type": "https://tools.ietf.org/html/rfc9110#section-15.6.1",
-  "title": "An error occurred while processing your request.",
-  "status": 500,
-  "detail": "An unexpected internal error occurred.",
-  "instance": "/api/test",
+  "type": "https://tools.ietf.org/html/rfc9110#section-15.5.5",
+  "title": "Not Found",
+  "status": 404,
   "errors": [
     {
-      "code": "TestInternalCode",
-      "message": "TestInternalMessage"
+      "code": "TestNotFoundCode",
+      "message": "Test not found message"
     }
   ],
-  "traceId": "1ca274bed877413cefd8094fc63bd559"
+  "traceId": "c771b28502648371f14885924e6d1767"
 }
 ```
 
@@ -118,14 +110,12 @@ Example:
   "type": "https://tools.ietf.org/html/rfc9110#section-15.6.1",
   "title": "An error occurred while processing your request.",
   "status": 500,
-  "detail": "An unexpected error occurred.",
-  "instance": "/api/test",
   "errors": [
     {
       "code": "InternalError",
       "message": "An unexpected internal error occurred."
     }
   ],
-  "traceId": "b217277ea131750f161bc6e8d8b33302"
+  "traceId": "9bf8d72774b6f2d97cac7607bb19f408"
 }
 ```

CR.Exceptions.Tests.Shared/TestInternalException.cs

@@ -1,10 +1,10 @@
 using System.Collections.Immutable;
 
 namespace CR.Exceptions.Tests.Shared;
 
 public sealed class TestInternalException : InternalException
 {
-    private static readonly ImmutableArray<CrError> _errors = [new("TestInternalCode", "TestInternalMessage")];
+    private static readonly ImmutableArray<CrError> _errors = [new("TestInternalCode", "Test internal message")];
 
     public TestInternalException() : base(_errors) { }
 }

CR.Exceptions.Tests.Shared/TestNotFoundException.cs

@@ -0,0 +1,10 @@
+using System.Collections.Immutable;
+
+namespace CR.Exceptions.Tests.Shared;
+
+public sealed class TestNotFoundException : NotFoundException
+{
+    private static readonly ImmutableArray<CrError> _errors = [new("TestNotFoundCode", "Test not found message")];
+
+    public TestNotFoundException(Exception? innerException = null) : base(_errors, innerException) { }
+}

CR.Exceptions.Tests.Shared/TestUnknownException.cs

@@ -4,7 +4,7 @@ namespace CR.Exceptions.Tests.Shared;
 
 public sealed class TestUnknownException : CrException
 {
-    private static readonly ImmutableArray<CrError> _errors = [new("TestUnknownCode", "TestUnknownMessage")];
+    private static readonly ImmutableArray<CrError> _errors = [new("TestUnknownCode", "Test unknown message")];
 
     public TestUnknownException(Exception? innerException = null) : base(_errors, "Test unknown exception message", innerException) { }
 }

CR.Exceptions/ConflictException.cs

@@ -9,7 +9,7 @@ protected ConflictException(ImmutableArray<CrError> errors, Exception? innerExce
     {
     }
 
-    protected ConflictException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected ConflictException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

CR.Exceptions/CrError.cs

@@ -2,13 +2,12 @@
 
 public record class CrError
 {
-    public string Code { get; init; }
-    public string Message { get; init; }
+    public string Code { get; }
+    public string? Message { get; }
 
-    public CrError(string code, string message)
+    public CrError(string code, string? message = null)
     {
         ArgumentException.ThrowIfNullOrEmpty(code);
-        ArgumentException.ThrowIfNullOrEmpty(message);
 
         Code = code;
         Message = message;

CR.Exceptions/CrException.cs

@@ -6,9 +6,8 @@ public abstract class CrException : Exception
 {
     public ImmutableArray<CrError> Errors { get; }
 
-    protected CrException(ImmutableArray<CrError> errors, string message, Exception? innerException = null) : base(message, innerException)
+    protected CrException(ImmutableArray<CrError> errors, string? message = null, Exception? innerException = null) : base(message, innerException)
     {
-        ArgumentException.ThrowIfNullOrEmpty(message);
         errors.ThrowIfEmptyOrContainsNull();
 
         Errors = errors;

CR.Exceptions/ForbiddenException.cs

@@ -9,7 +9,7 @@ protected ForbiddenException(ImmutableArray<CrError> errors, Exception? innerExc
     {
     }
 
-    protected ForbiddenException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected ForbiddenException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

CR.Exceptions/InternalException.cs

@@ -9,7 +9,7 @@ protected InternalException(ImmutableArray<CrError> errors, Exception? innerExce
     {
     }
 
-    protected InternalException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected InternalException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

CR.Exceptions/Mapping/ExceptionFactory.cs

@@ -15,6 +15,6 @@ public bool TryCreate(string code, [MaybeNullWhen(false)] out CrException except
 
     private static CrException ExecuteFactory(Func<CrException> factory)
     {
-        return factory() ?? throw new InvalidOperationException($"{nameof(factory)} '{factory.Method.Name}' returned null.");
+        return factory() ?? throw new InvalidOperationException($"{nameof(factory)} returned null.");
     }
 }

CR.Exceptions/Mapping/ExceptionTranslator.cs

@@ -15,8 +15,6 @@ public bool TryTranslate(Exception exception, [MaybeNullWhen(false)] out CrExcep
 
     private static CrException ExecuteTranslator(Exception innerException, Func<Exception, CrException> translator)
     {
-        return
-            translator(innerException) ??
-            throw new InvalidOperationException($"{nameof(translator)} '{translator.Method.Name}' returned null.");
+        return translator(innerException) ?? throw new InvalidOperationException($"{nameof(translator)} returned null.");
     }
 }

CR.Exceptions/NotFoundException.cs

@@ -9,7 +9,7 @@ protected NotFoundException(ImmutableArray<CrError> errors, Exception? innerExce
     {
     }
 
-    protected NotFoundException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected NotFoundException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

CR.Exceptions/README.md

@@ -15,14 +15,6 @@ This package contains only the core exception model and has no ASP.NET Core depe
 
 ---
 
-# Installation
-
-```bash
-dotnet add package CrCore.Exceptions
-```
-
----
-
 # Error Model
 
 Every application error is represented by `CrError`.

CR.Exceptions/UnauthorizedException.cs

@@ -9,7 +9,7 @@ protected UnauthorizedException(ImmutableArray<CrError> errors, Exception? inner
     {
     }
 
-    protected UnauthorizedException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected UnauthorizedException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

CR.Exceptions/UnprocessableException.cs

@@ -9,7 +9,7 @@ protected UnprocessableException(ImmutableArray<CrError> errors, Exception? inne
     {
     }
 
-    protected UnprocessableException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected UnprocessableException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

CR.Exceptions/ValidationException.cs

@@ -5,11 +5,11 @@ namespace CR.Exceptions;
 public abstract class ValidationException : CrException
 {
     protected ValidationException(ImmutableArray<CrError> errors, Exception? innerException = null)
-        : base(errors, "The provided data is invalid. Check the specific errors list.", innerException)
+        : base(errors, "The provided data is invalid.", innerException)
     {
     }
 
-    protected ValidationException(ImmutableArray<CrError> errors, string message, Exception? innerException = null)
+    protected ValidationException(ImmutableArray<CrError> errors, string? message, Exception? innerException = null)
         : base(errors, message, innerException)
     {
     }

README.md

@@ -8,14 +8,14 @@ A lightweight framework for defining application errors, creating typed exceptio
 
 Core library for defining application errors, exception categories and their creation.
 
-Documentation:
-[CR.Exceptions README](./CR.Exceptions/README.md)
+[README](./CR.Exceptions/README.md)
+[NuGet](https://www.nuget.org/packages/CrCore.Exceptions/)
 
 ---
 
 ### CR.Exceptions.AspNet
 
 ASP.NET Core integration for handling exceptions and converting them into RFC 7807 ProblemDetails responses.
 
-Documentation:
-[CR.Exceptions.AspNet README](./CR.Exceptions.AspNet/README.md)
+[README](./CR.Exceptions.AspNet/README.md)
+[NuGet](https://www.nuget.org/packages/CrCore.Exceptions.AspNet/)