fix: Reorder binary operators to fix parser error#44
Open
exomo wants to merge 1 commit into
Open
Conversation
Parsing binary operators evaluates them in an or ("|") expression. Since
the parser evaluates them in order and returns the first matching
pattern, shorter patterns that are a prefix of a longer pattern and come
earlier in the order prevent the longer pattern from ever being parsed.
This was the case for the binary operators "<<" and ">>" making any
expression that contains one of the shift operators invalid.
(first < is parsed as the "<" operator, the second < can not be parsed
in that position.
The fix is fairly simple. The operators are reordered in the definition
of binaryOperations to make sure "<<" is evaluated before "<".
Add some additional test cases for binary operation expressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
Parsing binary operators evaluates them in an or ("|") expression. Since the parser evaluates them in order and returns the first matching pattern, shorter patterns that are a prefix of a longer pattern and come earlier in the order prevent the longer pattern from ever being parsed.
This was the case for the binary operators "<<" and ">>" making any expression that contains one of the shift operators invalid. (first < is parsed as the "<" operator, the second < can not be parsed in that position.
The fix is fairly simple. The operators are reordered in the definition of binaryOperations to make sure "<<" is evaluated before "<".
Add some additional test cases for binary operation expressions.