Repository navigation
Conversation
A token that extends the previous grapheme cluster (a ZWJ joining another emoji, a combining mark, an Indic vowel sign or virama) leaves the Character count unchanged. VanillaDecodingStrategy then failed its count/hasPrefix test and re-emitted the whole line so far, and dropped the trailing text in flushTrailingText; the two constrained strategies took a Character-wise commonPrefix and re-emitted the extended grapheme. Compare and slice Unicode scalars in all three places, and add tests that stream such text one UTF-8 byte per token through each strategy. (cherry picked from commit e3f5c0c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315. Fix authored by @iannellomarco (cherry-picked, authorship preserved).
A token that extends the previous grapheme cluster (a ZWJ joining another emoji, a combining mark, an Indic vowel sign/virama) leaves the Swift
Charactercount unchanged. The streaming strategies then mis-detected "no new text" —VanillaDecodingStrategyre-emitted the whole line so far and dropped the trailing text influshTrailingText; the two constrained strategies re-emitted the extended grapheme via a Character-wise common prefix. Compare and slice the delta by Unicode scalars in all three places;StreamingTextDeltaTestsstreams such text one UTF-8 byte per token through each strategy.This fixes the delta correctness (deltas now concatenate to the decoded text). It does not change that streaming re-decodes the full token sequence each step — tracked separately in #341 (incremental scalar detokenizer).