Select isolate exposing ext.flutter.driver during connection - #911
Closed
OksanaTka wants to merge 2 commits into
Closed
Select isolate exposing ext.flutter.driver during connection#911OksanaTka wants to merge 2 commits into
OksanaTka wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Android, a data-only FCM message can start a headless Flutter engine to run a
firebase_messagingbackground handler before the application's UI engine starts.This can result in two root isolates named
main:ext.flutter.driver.ext.flutter.driver.During automatic discovery,
connectSocketcurrently selects the first isolate whose name containsmainand polls only that isolate.If the background isolate appears first, connection fails with:
This is related to the two-
main-isolate behavior reported in #756.Fix
For automatic isolate discovery, this change:
getIsolate.extensionRPCscontainsext.flutter.driver.appium:isolateIdbehavior by validating only the configured isolate.Manual verification
I verified the change with an Android terminated-app notification flow:
main.ext.flutter.driver.flutter:connectObservatoryWsUrlsucceeded.Validation
npm run buildnpm run lintnpm run format:check