Skip to content

Metrics - 01 foundation - #121

Closed
jitendradhawan wants to merge 2 commits into
appform-io:2.xfrom
jitendradhawan:metrics/01-foundation
Closed

jitendradhawan wants to merge 2 commits into
appform-io:2.xfrom
jitendradhawan:metrics/01-foundation

Conversation

@jitendradhawan

Copy link
Copy Markdown
Contributor

Summary

Adds shared metrics infrastructure and propagates upstream identity through Ranger's common APIs.

Target branch: 2.x

Changes

  • Adds MetricRecorder backed by Dropwizard MetricRegistry.
  • Adds DataStoreType (ZK, HTTP, DROVE).
  • Adds getUpstreamId() and getDataStoreType() metadata to NodeDataSource and NodeDataSink.
  • Propagates upstreamId through finder/provider builders, hub clients, backend connectors, and factories.
  • Adds Dropwizard Metrics and validation dependencies required by the new contracts.
  • Keeps all metric recording calls and bundle initialization out of this change; those are covered by subsequent stacked MRs.

Compatibility / Migration

This is a source-compatible change only for callers that update their implementations and builders:

  • Custom sources and sinks must implement getUpstreamId() and getDataStoreType().
  • Custom builder overrides must accept upstreamId in source/sink factory methods.
  • Direct client, builder, connector, and factory callers must propagate a non-null upstream ID.

Testing

  • Full reactor compilation passes with mvn -DskipTests compile.
  • Focused behavior tests are added in later backend/core MRs.

Reviewer Guide

  • Verify upstream ID propagation does not alter discovery behavior.
  • Check that public/protected extension points are consistently updated.
  • Confirm MetricRecorder is a no-op before registry initialization.
  • Confirm this MR contains no backend-specific metric side effects.

@jitendradhawan jitendradhawan changed the title Metrics- 01 foundation Metrics - 01 foundation Sep 21, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant