Repository navigation
fix: close the hosted macOS agent-device connection on stop - #5658
Merged
Merged
Conversation
Collaborator
Author
|
Fresh independent review after Full suite success found no actionable issues at c9ab2e5. Stop checks the deterministic name and any explicit literal name against the canonical config before closing or disconnecting. The fallback quotes the exact name without printing the vendor error or config. All 164 focused cases passed independently. Live hosted Desktop verification was unavailable because the mini was paused. #5604 remains open for names or state directories that were never supplied to Stim. Configured Codex review:
|
janicduplessis
marked this pull request as ready for review
November 13, 2026 06:12
janicduplessis
added this pull request to the merge queue
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
stim stopqueried the unnamed agent-device remote connection for a hosted macOS app. Agent-device refuses unnamed commands on leased connections, so the host stops the app while the agent's saved connection stays open.Solution
Include a stable workspace-specific session name in the hosted macOS command. On Stop, check that name and any explicit
AGENT_DEVICE_SESSION. Close and disconnect a name only when agent-device reports that exact name and the same canonical remote config. If cleanup of a verified connection fails, print the exact disconnect command and let the hosted Stop finish.An earlier connection can be checked by running Stop with its session name and the same agent-device state directory. Stop cannot discover an ad hoc name or a different state directory the caller does not supply. The guide describes how to disconnect those manually.
Test plan
Related to #5604